stack-overflow-copy-paste icon indicating copy to clipboard operation
stack-overflow-copy-paste copied to clipboard

Published 20 hours ago • verified publisher icon eggheadio-github

Add a findDuplicates function

Open diwesh87 opened this issue 8 years ago • 14 comments

Hi got here watching your course "How to Contribute to an Open Source project on GitHub. I would like to add a "findDuplicates" function. The original solution can be found here at Find duplicate values in a JavaScript array

diwesh87 avatar Nov 17 '16 14:11 diwesh87

Awesome! I recommend my favorite answer, but feel free to use whichever you like. I'm looking forward to seeing your implementation!

kentcdodds avatar Nov 17 '16 15:11 kentcdodds

I want to contribute to this issue. This is my first time to contribute in githup repository.

engeman2008 avatar Dec 01 '16 19:12 engeman2008

@engeman2008, thank you for your interested. Do you think you could actually create your own issue with a different Stack Overflow answer? I would prefer to leave this one for @diwesh87 who had the idea in the first place :)

Thanks!

kentcdodds avatar Dec 01 '16 19:12 kentcdodds

Okay. i didnt get the idea at first. i thought i could contribute to any issue. Thanks.

engeman2008 avatar Dec 01 '16 19:12 engeman2008

Thanks @engeman2008, I should probably open up a few issues for people to select... Thanks for understanding :)

kentcdodds avatar Dec 01 '16 19:12 kentcdodds

Yes, this would be great. Thanks.

engeman2008 avatar Dec 01 '16 19:12 engeman2008

I added some.

kentcdodds avatar Dec 01 '16 22:12 kentcdodds

@kentcdodds Are you opposed to people opening issues as ideas? Or should they take only open ones? Or can they only open issues they intend to solve?

Just trying to get a sense of what you're expecting regarding issues for clarity.

Cheers!

mtheoryx avatar Dec 01 '16 22:12 mtheoryx

I would prefer people to open their own. But if someone needs some direction, having some existing issues is helpful. Feel free to add some if you have ideas @mtheoryx :)

kentcdodds avatar Dec 01 '16 22:12 kentcdodds

Hi @kentcdodds..I am following your course on 'How to contribute to open source projects' and would love to contribute to issues. Could you open some new issues you want to fix/add? It would make the start easier.Thanks!

goanpixie avatar Apr 13 '17 22:04 goanpixie

@goanpixie, glad that you're going through the series. I think it actually would be a more full experience if you file the issue to start with :smile:

kentcdodds avatar Apr 13 '17 22:04 kentcdodds

Sounds good!:) I just filed an issue.

goanpixie avatar Apr 14 '17 00:04 goanpixie

As a newbie, how do I find an issue to work in? This is kind of overwhelming as a beginner.

ruimprego avatar Jul 31 '17 15:07 ruimprego

Hi @captainSpades, The best way to contribute to this repo is to come up with your own stack overflow answer you'd like to add to the project and file an issue. You can see what others have done if you need some inspiration for what kinds of things that work here. And be sure to watch this

Good luck!

kentcdodds avatar Aug 01 '17 19:08 kentcdodds