eugene yokota comments

Results 705 comments of


                                            eugene yokota

Default `Pickler[java.io.File]` is broken

Thanks for the report. This is a variation of #60/#296.

Handle sealed classes in check for non-cyclic types

Saved the original branch to `issue-128-original`, and rebased this one against `0.10.x`.

Handle sealed classes in check for non-cyclic types

@jsuereth The commit message says: > When deciding to delay the initialization of fields due to possible cycles,... If we flip this statement, we can derive: When there are possible...

Running into problems when pickling Map and HashMap

I was able to reproduce this problem using Pickling 0.10.0.

Consider bumping scala-compiler's `scala-xml` dependency to 2.x in Scala 2.12

Agreed on scala-xml 2.x. I am happy to update sbt dependency in the next feature release 1.8.x. #### persistent versioning? Related thought. In the age of scala-streward where people bump...

Pickling an empty list does not produce an empty JSON array

I think the readme or the talk said pickling's JSON implementation inlines the String operations on compile-time so the runtime performance is really good. sbt/serialization's implementation is less hardcore about...

exception during macro expansion: value Predef is not a package

Another exception during macro expansion. Same spot in code. ``` exception during macro expansion: [error] java.lang.RuntimeException: malformed Scala signature of Short at 45; bad type tag: 6 [error] at scala.reflect.internal.pickling.UnPickler$Scan.errorBadSignature(UnPickler.scala:833)...

Doesn't work when there's a package named "scala".

I can reproduce this with Pickling 0.10.0.

v 0.9.1 unpickle[Any] works for array but not for list

Using Pickling 0.10.0, I get opposite result on REPL: ``` scala scala> import scala.pickling.Defaults._ import scala.pickling.Defaults._ scala> import scala.pickling.json._ import scala.pickling.json._ scala> Array(5 -> 0.5d, 6 -> 0.6d).pickle res0: pickling.json.pickleFormat.PickleType...

Don't put loose files like `.scala_history_jline3` in the root of user dirs

> No-one should have to spend a millisecond thinking about or cleaning up after your software when they're not using it. Stop fucking littering. I am so fucking sick of...