Edwin Mak

Results 52 comments of Edwin Mak
trafficstars

@dorner I think this is good to go. I QA all that I mentioned above and I did notice one small thing that I think we can come back to...

@dorner this happens when the `session[:role_id]` hasn't been defined yet and it sets it to the first role according to the definition of `current_role`. The issue with this is that...

@dorner this is after accepting an invite that logs me in via different means, could that be the reason why it isn't working for this case?

@dorner it's handled by devise and I believe we can override the controller lightly to add that logic you shared above.

@dorner hey there, the way to get here is by accepting an invite from creating an organization. The flow starts from the splash page to request an account.

Nice @dorner - I'll give it one last QA and if its good. Let's mergy merge

Nice! All green works like expected!

Still pending some fixes and after that I think we mergey merge

Awesome! Thanks @dorner just QA'ed this and it works. A bit of a side thought for a future issue, perhaps we can use something like https://adminlte.io/themes/v3/pages/examples/invoice.html from the theme which...

@l3pp4rd sounds good to me. I agree that an overuse of the `Any*Types` could be encouraging the wrong sort of behavior when building tests.