Edward Hartnett

Results 327 comments of Edward Hartnett

@arunchawla-NOAA perhaps you can jump in and try and shake loose some answers from the land team? There are a bunch of constants in the code, and we're trying to...

The paper you cite has been added to the documentation. I have read the relevant section and it does not provide the numbers used in the code. The goal here...

OK, thanks, that is helpful. We will ponder how to best handle constants taken from other codes.

OK, let's confine the discussion to one set of parameters, so we have a specific example. In the chgres_cube file program_setup.f we have: ``` ! using stasgo table data bb_statsgo...

OK, thanks. Should we be looking at a fork for these numbers?

OK. In that fork I see this: ``` ! using stasgo table BB =(/4.05, 4.26, 4.74, 5.33, 5.33, 5.25, & 6.77, 8.72, 8.17, 10.73, 10.39, 11.55, & 5.25, 4.26, 4.05,...

float16 is supported in Fortran, not in C. This is related to #2650.

This is now happening in the CI.

@junwang-noaa and @DusanJovic-NOAA the settings on this repo should be set so that no PR which breaks CI can be merged. ![image](https://github.com/NOAA-EMC/fv3atm/assets/38856240/d680c2a4-e9ab-45c2-b7a1-ae39d7b077f5)