tornadofx2 icon indicating copy to clipboard operation
tornadofx2 copied to clipboard

Split code into core and submodules for non-core code

Open ctadlock opened this issue 5 years ago • 5 comments

The first commit for this merge request. DO NOT MERGE YET

Items:

  • Split project into parent and submodules
  • Moved all code into tornadofx-core submodule
  • Completely rewrote the pom.xml files
  • Did not move over test code; I think this should be reviewed first
  • Did not move over documentation via dokka; not sure how this works yet

ctadlock avatar May 19 '20 22:05 ctadlock

https://github.com/edvin/tornadofx2/issues/3

ctadlock avatar May 19 '20 22:05 ctadlock

@edvin Take a look at this for the structure; you should be able to pull it down and use it. I was able to use it in our app without any issue. If youre OK with this, can then work on moving the components out of core into their other projects.

ctadlock avatar May 19 '20 22:05 ctadlock

I converted this PR to a draft/WIP to prevent accidental merging. When you're ready for it to be merged, mark it as "Ready for review".

ruckustboom avatar May 20 '20 17:05 ruckustboom

I converted this PR to a draft/WIP to prevent accidental merging. When you're ready for it to be merged, mark it as "Ready for review".

Thanks. Ill be the one to merge it anyways, but good to follow the right process.

ctadlock avatar May 21 '20 04:05 ctadlock

Going to merge this in and start moving forward...

ctadlock avatar May 25 '20 19:05 ctadlock