Edward Delaporte

Results 53 comments of Edward Delaporte

#88 May help us with investigating this in the future. And @ddriddle's comment here might be an important part of this: https://github.com/techservicesillinois/awscli-login/issues/23#issuecomment-777193220

Pushed the wrong 'comment' button.

Per recent discussion, work in the AWS API V2 support milestone might allow us to revisit this. Can't promise a solution right now, but we're still thinking about this one.

@ckuehn-uiuc The daemon will be retired with the next release, to allow AWS CLI V2 support. Refresh will still be supported, and won't require the daemon. See #106 for details.

My best guess on the failing test is some odd interaction with the 'or' here: https://github.com/techservicesillinois/awscli-login/blob/109d0dfa738f442048deda4eaa9dd084b3dd4579/src/awscli_login/config.py#L142-L143 But as far as I can tell it should work as written. ?

I'm guessing the issue is here: https://github.com/techservicesillinois/awscli-login/blob/109d0dfa738f442048deda4eaa9dd084b3dd4579/src/awscli_login/__init__.py#L103-L113 Note that `verify-ssl-certificate` has dashes while other versions have underscores.

@ddriddle @kwessel I think I've found our unit test failure source. Per the comments, `verify_ssl_certificate` also needs a default value here. As @ddriddle suggested, we should also capture this into...

@kwessel Here's the change I think will fix the unit tests, as a patch file: ``` From c6a72677f6bc2dd5dd2261922acbbb8ea1006216 Mon Sep 17 00:00:00 2001 From: Edward Delaporte Date: Wed, 18 May...

@kwessel It just struck me that I could fork your fork to work on the unit tests, if you prefer, as well.

@knoxilla Thanks for the feedback! Yes - we need to do a quick pass through the documentation on setting this up, and ensure there are no remaining blockers. ## Tasks...