list icon indicating copy to clipboard operation
list copied to clipboard

Fix: Unable to Delete List items (ordered and unordered)

Open donnfelker opened this issue 1 year ago • 4 comments

This includes the fix from #95 as well as an additional fix to re-attach the listeners after the element.replaceWith was invoked.

The backspace update from #95 worked, but the event listeners are lost when the toggleTune is invoked. This PR adds the listeners back after the tune is invoked.

The listeners are lost because replaceWith does not propagate the existing listeners to the new element.

Also related to #90

donnfelker avatar Apr 14 '24 00:04 donnfelker

Other devs: See #90 for a code snippet you can use to fix it locally until this is merged.

donnfelker avatar Apr 14 '24 00:04 donnfelker

Just tested it and it seems to work! Could one of the contributors take a look at this?

mve avatar Jul 01 '24 10:07 mve

I tested it too. It seems to work. I think this is a very important fix for this plugin. Could one of the contributors take a look at this? Thanks a lot.

Sozialarchiv avatar Jul 23 '24 04:07 Sozialarchiv

@neSpecc How does it work with the versioning? Does every pull request need a version in package.json? If yes then here it is missing.

Sozialarchiv avatar Jul 25 '24 06:07 Sozialarchiv