fdb icon indicating copy to clipboard operation
fdb copied to clipboard

Feature/fdb 326 select

Open danovaro opened this issue 6 months ago • 2 comments

fix for FDB-326 and FDB-329

  1. In case of fdb select, if a schema is provided at the top level, then it is propagated as the default schema for all the FDBs.
  2. add the ability to exclude some values in the schema regexes (useful to prevent matching on list. For archival, the rule ordering could have been enough)

📚 Documentation preview 📚: https://ecmwf-fdb--120.org.readthedocs.build/en/120/

danovaro avatar Apr 30 '25 12:04 danovaro

Codecov Report

Attention: Patch coverage is 19.60784% with 41 lines in your changes missing coverage. Please review.

Project coverage is 70.77%. Comparing base (7eaed21) to head (fb94e60). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/fdb5/rules/ExcludeAll.cc 0.00% 37 Missing :warning:
src/fdb5/rules/SchemaParser.cc 77.77% 2 Missing :warning:
src/fdb5/api/SelectFDB.cc 75.00% 1 Missing :warning:
src/fdb5/rules/ExcludeAll.h 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #120      +/-   ##
===========================================
- Coverage    70.94%   70.77%   -0.18%     
===========================================
  Files          282      284       +2     
  Lines        16002    16049      +47     
  Branches      1647     1655       +8     
===========================================
+ Hits         11353    11359       +6     
- Misses        4649     4690      +41     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 30 '25 13:04 codecov-commenter

Related: It would also be useful to include the concept of NOT / Exclusion in the SelectFDB regexes. Matt was asking for this.

ChrisspyB avatar Apr 30 '25 13:04 ChrisspyB

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/15763594772.

github-actions[bot] avatar Jun 19 '25 17:06 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/15764155198.

github-actions[bot] avatar Jun 19 '25 18:06 github-actions[bot]