fckit icon indicating copy to clipboard operation
fckit copied to clipboard

Raise minimum cmake version to 3.19

Open awnawab opened this issue 4 weeks ago • 1 comments

A small PR that raises the minimum cmake version to 3.19 and also enforces the minimum for the populate workflow. This is needed to ensure the correct python interpreter after a system update in the Atos which installed python3.12.

awnawab avatar Nov 07 '25 14:11 awnawab

Hi @wdeconinck could you please review? Thanks!

awnawab avatar Nov 07 '25 14:11 awnawab

Raising the cmake minimum required may need coordination with @iainrussell . Iain, could you advise?

wdeconinck avatar Nov 10 '25 08:11 wdeconinck

It turns out that simply enforcing a minimum cmake version of 3.17 is also enough to fix the find_python behaviour this PR is addressing, so I've rolled it the minimum cmake version back to 3.17 as before.

awnawab avatar Nov 11 '25 13:11 awnawab

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 51.35%. Comparing base (67dd487) to head (63a3357).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #75   +/-   ##
========================================
  Coverage    51.35%   51.35%           
========================================
  Files           58       58           
  Lines         4812     4812           
  Branches       449      449           
========================================
  Hits          2471     2471           
  Misses        2341     2341           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Nov 11 '25 13:11 codecov-commenter