eckit Feature/add libfmt

Mar 21 '25 22:03 Ozaq

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14002135899.

Mar 21 '25 22:03 github-actions[bot]

Codecov Report

Attention: Patch coverage is 34.11420% with 450 lines in your changes missing coverage. Please review.

Project coverage is 62.99%. Comparing base (76a6f33) to head (8150253).

Files with missing lines	Patch %	Lines
third-party/fmt-11.1.4/include/fmt/format-inl.h	22.51%	320 Missing :warning:
third-party/fmt-11.1.4/src/os.cc	0.00%	106 Missing :warning:
third-party/fmt-11.1.4/include/fmt/os.h	0.00%	14 Missing :warning:
tests/format/test_format_log.cc	77.27%	5 Missing :warning:
third-party/fmt-11.1.4/include/fmt/chrono.h	55.55%	4 Missing :warning:
tests/format/test_format_to.cc	98.00%	1 Missing :warning:

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
- Coverage    64.69%   62.99%   -1.70%     
===========================================
  Files         1107     1120      +13     
  Lines        56064    58603    +2539     
  Branches      4235     4543     +308     
===========================================
+ Hits         36268    36918     +650     
- Misses       19796    21685    +1889

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

:snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Mar 21 '25 22:03 codecov-commenter

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14002581491.

Mar 21 '25 23:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14003492452.

Mar 22 '25 01:03 github-actions[bot]

(Not a review)

This is an ideal candidate for git submodules. You can pin to a version, a branch typically main/master. Don't discard the testing....

Mar 22 '25 21:03 pmaciel

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14013287677.

Mar 22 '25 23:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14013322210.

Mar 22 '25 23:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14023372025.

Mar 23 '25 21:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14023633597.

Mar 23 '25 22:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14024041579.

Mar 23 '25 23:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14029932450.

Mar 24 '25 07:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14029984133.

Mar 24 '25 07:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14031334889.

Mar 24 '25 09:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14031516324.

Mar 24 '25 09:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14158617423.

Mar 30 '25 18:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14158843892.

Mar 30 '25 18:03 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14170190234.

Mar 31 '25 11:03 github-actions[bot]

So the find_dependency stuff is working properly now - also from a bundle.

Now we just need to see why the pyfdb runner with gnu8.5 is using the lib64/ instead of lib/ path

Apr 03 '25 10:04 pgeier

Private downstream CI failed. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14241788931.

Apr 03 '25 12:04 github-actions[bot]

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14242362353.

Apr 03 '25 12:04 github-actions[bot]

In a separate PR I'm proposing to use git submodules as a way to integrate third-party libraries functionality without copying and with direct access to said libraries versioning. We already have the example of using xxHash, and for libfmt I'm of the opinion of not copying code into eckit, especially if that means stripping functionality (documentation, testing).

if you find you have opinions on this please add yourself to review the PR!

Apr 03 '25 12:04 pmaciel