atlas icon indicating copy to clipboard operation
atlas copied to clipboard

Feature/area extraction test

Open antons-it opened this issue 1 year ago • 4 comments

Area extraction unit tests that fails with -np > 2

antons-it avatar Mar 08 '24 09:03 antons-it

CLA assistant check
All committers have signed the CLA.

FussyDuck avatar Mar 08 '24 09:03 FussyDuck

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.08%. Comparing base (de3896f) to head (d56b06d).

Files Patch % Lines
...as/meshgenerator/detail/StructuredMeshGenerator.cc 0.00% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
+ Coverage    80.07%   80.08%   +0.01%     
===========================================
  Files          859      860       +1     
  Lines        63682    63730      +48     
===========================================
+ Hits         50993    51039      +46     
- Misses       12689    12691       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 08 '24 10:03 codecov-commenter

This test is still failing with MPI_SIZE = 120 and with grid O400. Partition 76 coincidentally ends up with only very few points for which a mesh cannot be generated. image

A workaround, but NOT the solution, could be choosing different MPI_SIZE (e.g. 128) or moving the area domain to include more points on partition 76 (or none at all).

wdeconinck avatar Mar 11 '24 10:03 wdeconinck

This test is still failing with MPI_SIZE = 120 and with grid O400.

Other possibility is to use functionspace::PointCloud as a target. Then no mesh is attempted to be generated for partition 76

wdeconinck avatar Mar 11 '24 10:03 wdeconinck