eclipsesource
Support for MUI v7
Is your feature request related to a problem? Please describe.
Currently, JsonForms supports MUI (Material UI) versions v5 and v6. However, MUI v7 has been released, and many projects are starting to migrate or have already migrated to v7. The lack of support for MUI v7 makes it difficult to integrate JsonForms into projects using the latest version of MUI, leading to compatibility issues, dependency conflicts, and additional maintenance overhead when trying to downgrade or patch versions.
Describe the solution you'd like
Please add support for MUI v7 so that JsonForms can be used seamlessly with the latest version of Material UI. This will help projects that have already upgraded to MUI v7 integrate JsonForms without compatibility issues.
Describe alternatives you've considered
If full support for MUI v7 is not yet possible, any workaround or suggestions to help integrate JsonForms with MUI v7 would be greatly appreciated.
Package
React Material Renderers
Additional context
Thanks for the report. In general we would like to support the latest versions of our dependencies. Would you like to add the support for MUI v7? If possible we usually try to be backwards compatible, however if MUI v7 has breaking changes then it's fine to only support that one.
I'm running with mui v7 right now, and the problems seem minor. From what I can see:
- Bump peer dependency versions
- Fix accordion rendering for lists
Everything else appears to be working and looking fine (so far)!
@sdirix We upgraded our project to MUI V7, and JSONForms is on 3.6.0. The Grid layout is broken, as in MUI V7, where Grid and related components are renamed to GridLegacy, and Grid2 is renamed to Grid. The workaround we used is to create a custom renderer for HorizontalLayoutRenderer, but it is not working for all scenarios. If JSONForms is planning to support MUI V7, based on your comment, it would only support Grid and not GridLegacy? I want to give it a go for upgrading MUI version in JSONForms to V7.
We always want to support the latest version of our dependencies. With this change it seems we can only support Mui v7 going forward. This is fine, we can not support all ranges of our dependencies.
For now I'm fine with going forward changing Grid to GridLegacy. Of course, if you want to support the new API instead, that would also be fine.
@ganapatib Do you, or someone else, want to contribute the upgrade to Mui v7?
I did give it a try to see if it works for our project. Here is the branch - https://github.com/ganapatib/jsonforms/tree/feature-mui-7-upgrade. I was able to build the project and run the seed application after the upgrade.
I did give it a try to see if it works for our project. Here is the branch - https://github.com/ganapatib/jsonforms/tree/feature-mui-7-upgrade. I was able to build the project and run the seed application after the upgrade.
Your fork looks like it already covered this; you just have some failed tests.
Regarding the failed tests, every time I run them locally, a different one fails with the same permission denied issue. Appreciate some guidance there.
Regarding the failed tests, every time I run them locally, a different one fails with the same permission denied issue. Appreciate some guidance there.
have no idea, need to look it up, maybe try to open the pr and then we can check the build logs