jsonforms icon indicating copy to clipboard operation
jsonforms copied to clipboard

fix VNumberInput import dependency in vuetify > 3.8.0

Open viktor-c opened this issue 7 months ago • 5 comments
trafficstars

Fix #2434

viktor-c avatar Apr 05 '25 18:04 viktor-c

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 05 '25 18:04 CLAassistant

Deploy Preview for jsonforms-examples failed.

Name Link
Latest commit ca0b0ef44371812276520c905740d9c26b1a8d05
Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/6808a4215e3e450008c62150

netlify[bot] avatar Apr 05 '25 18:04 netlify[bot]

Hi @viktor-c , thanks for the contribution :heart: However, your changes are not sufficient: Currently, we allow vuetify ^3.6.6 in the peer dependencies of the vue-vuetify package. With this, your changes do not work. We need to increase the version range to ^3.8.0. We can do this. Please adapt the PR accordingly :)

lucas-koehler avatar Apr 10 '25 10:04 lucas-koehler

Coverage Status

coverage: 82.517%. remained the same when pulling ca0b0ef44371812276520c905740d9c26b1a8d05 on viktor-c:master into 52182632589658b61394c870df1cefacff7d8775 on eclipsesource:master.

coveralls avatar Apr 23 '25 08:04 coveralls

Hi @viktor-c , Thanks for the update! I added the missing update for the dev dependency of vuetify ^3.8.0 and regenerated the pnpm lock file to use this. Unfortunately, this seems to break the preview and affects the build on windows and mac. Could you have a look what causes this? Netlify preview build logs: https://app.netlify.com/sites/jsonforms-examples/deploys/6808a4215e3e450008c62150

lucas-koehler avatar Apr 23 '25 09:04 lucas-koehler

Thanks again for the PR. Closing this as it is superseded by https://github.com/eclipsesource/jsonforms/pull/2468 updating to Vuetify ^3.9 and Vue ^3.5

lucas-koehler avatar Jul 18 '25 14:07 lucas-koehler