initial contribution for vue-vuetify renderer set
@sdirix please review the initial contribution that have the changes that fixes the vue3 integration. Few things to note:
- The original example data in the vuetify render set was not migrated since we do have an example set with the exceptions for few examples ported - additional properties, login form and etc. The only issue here is that the original examples were having the vuetify UI options that were not included or ported.
- few minor fixed in the core (issues with undefined in the core)
- upgrade of
ajv-i18nsince the Vite do not like the require when expecting to use import
Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| Latest commit | b6ad6272adc8ee5a38d31cee401f8c376d4c89e1 |
| Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/66c6063bb232c8000936a2a8 |
| Deploy Preview | https://deploy-preview-2341--jsonforms-examples.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@sdirix can you review and check why we have out of memory failure on the build machine ? Perhaps we need a build machine with more memory ?
@sdirix the build is fixed - I had to change
"build-only": "vite build",
to
"build-only": "NODE_OPTIONS=\"--max-old-space-size=4096\" vite build",
in the vuetiy package - if you want you can remove that from there and place it in the ci.yaml the same way how we set that for test to be set on build as well but that is up to you.
Thanks! I plan to take a look at this PR next week.
I was wondering whether we should preserve the history of the other repository, i.e. instead of copying all files over to here, we can add the vue3-branch into this repository as an orphan-branch and then do a merge commit with the content of the first commit here. This would keep the history.
Suggestion: Once this PR here is in a good state and reviewed, I can do as suggested above with your contribution here as a commit on top.
Note that we currently lose the new features we recently introduced in the vue3 branch, especially the touch-error filtering (https://github.com/eclipsesource/jsonforms-vuetify-renderers/pull/107), but also the improved exports (https://github.com/eclipsesource/jsonforms-vuetify-renderers/pull/109 & https://github.com/eclipsesource/jsonforms-vuetify-renderers/pull/110)
Can you re-integrate those changes?
coverage: 83.346% (+0.02%) from 83.322% when pulling 77f2714c9858aadb0a431ba6d9f3436884704295 on kchobantonov:vue-vuetify into 52aa15ace2f6c44300dad96901091b5f110e9ff2 on eclipsesource:master.
I can review and apply those changes - keep in mind that this PR will have almost the same thing as the PR for fixing the vue3 without the recent changes (few weeks ago) that were merged into that repo, and also this PR different from the PR against the older vue 3 vuetify 3 repository since I had to integrate that with the jsonforms main repo and most of the changes are in the example so both example apps are different between this PR and the other one. If you want to keep the history please create the proper PR with the history from the other repo and the either I or you can override that on top and have the history there.
@sdirix the requested PRs are applied to this PR
@kchobantonov Thank you very much!
coverage: 83.346% (+0.02%) from 83.322% when pulling 406ecc19a4b430b40370ff4465632f28246621eb on kchobantonov:vue-vuetify into 52aa15ace2f6c44300dad96901091b5f110e9ff2 on eclipsesource:master.
I'm looking at the PR. I plan to contribute the migration and finish the review next week.
coverage: 83.359% (+0.02%) from 83.337% when pulling fccbce5fef8e50d2e2b254808e12d41ebd4c6722 on kchobantonov:vue-vuetify into c00b664ced7bb17ca2ab838ce5da610790c76566 on eclipsesource:master.
I'm very eager to use this library, but the date picker issue hasn't been resolved yet. I see that this PR allows the use of the date picker component from Vuetify 3. I hope the code can be merged soon.