jsonforms icon indicating copy to clipboard operation
jsonforms copied to clipboard

Published 20 hours ago • verified publisher icon eclipsesource

Allow random fields in schema

Open buremba opened this issue 2 years ago • 5 comments

The Json Schema spec lets us have additional properties in the schema. https://swagger.io/docs/specification/openapi-extensions/

buremba avatar Feb 22 '23 01:02 buremba

Deploy Preview for jsonforms-examples failed.

Name Link
Latest commit bc7b6e8c830688ea3ce0721fb52f373cd2920b95
Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63f8dac3910a380008ba07a3

netlify[bot] avatar Feb 22 '23 01:02 netlify[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 22 '23 01:02 CLAassistant

Hello @buremba , thanks for your contribution :heart: . I'll discuss with the team whether we want to relax the type like this. Before we could merge this, you need to sign the Eclipse CLA (see comment https://github.com/eclipsesource/jsonforms/pull/2100#issuecomment-1439329066)

Also note that symbol cannot be used as a key here. This currently fails the build.

lucas-koehler avatar Feb 24 '23 11:02 lucas-koehler

Done, thanks @lucas-koehler! This feature is useful to me primarily because I infer the uischema and custom renderer from the original json schema properties with x-jsonform prefix.

buremba avatar Feb 24 '23 15:02 buremba

@lucas-koehler It looks like manual action needed to trigger CI: https://github.com/eclipsesource/jsonforms/actions/runs/4263956482

buremba avatar Feb 25 '23 17:02 buremba