zenoh icon indicating copy to clipboard operation
zenoh copied to clipboard

Refactor Liveliness implementation

Open fuzzypixelz opened this issue 1 year ago • 7 comments

Resolves https://github.com/eclipse-zenoh/zenoh/issues/864.

fuzzypixelz avatar Mar 26 '24 11:03 fuzzypixelz

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

eclipse-zenoh-bot avatar Mar 26 '24 11:03 eclipse-zenoh-bot

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

eclipse-zenoh-bot avatar Mar 26 '24 11:03 eclipse-zenoh-bot

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

eclipse-zenoh-bot avatar Mar 26 '24 11:03 eclipse-zenoh-bot

What works now:

  1. Liveliness declaration, w/o the interest protocol, in brokered scenarios
  2. Liveliness get, w/o the interest protocol, in brokered scenarios

I disabled unused_variables and dead_code lints to unblock the CI.

fuzzypixelz avatar Mar 28 '24 16:03 fuzzypixelz

@OlivierHecart I've addressed your remarks in 303ba3f, 1ae0b4f, b27525d and faeb4a6. Next I'll be merging interests into the pull request branch. Then I'll finally move on implement queries using tokens.

fuzzypixelz avatar Apr 30 '24 07:04 fuzzypixelz

I just merged interests into the pull request branch. By the time I finished my first merge conflict resolution, there were more merge conflicts waiting for me. These development branches getting a bit unwieldy.

I marked interest_id fields as todo!() during the resolution. I'll fix that next.

fuzzypixelz avatar May 06 '24 08:05 fuzzypixelz

The interest_id fields in the liveliness implementation now correctly mirror the subscriber implementation.

fuzzypixelz avatar May 06 '24 09:05 fuzzypixelz

Update:

  1. The .liveliness().get(..) API now sends interest declaration messages instead of requests.
  2. Incoming token declaration messages are sent to liveliness query callbacks.

fuzzypixelz avatar May 14 '24 07:05 fuzzypixelz