sumo icon indicating copy to clipboard operation
sumo copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-sumo

vClass-specific speeds in the lane parameter dialog of SUMO-GUI (ref #11100)

Open vijay-jaisankar opened this issue 3 years ago • 4 comments
trafficstars

ref: https://github.com/eclipse/sumo/issues/11100

In this PR, the following functionalities have been added:

  • Showing vClass specific speeds in the dialog box
  • Changing maxspeed to allowed speed

vijay-jaisankar avatar Jul 22 '22 13:07 vijay-jaisankar

Thank you! Please use the new c++ loop style for (const auto& elem : map) and do not make an unnecessary copy of the map (store it as a reference or do not store it at all). Also please change maxspeed to allowed speed for the existing entry as well

behrisch avatar Jul 23 '22 06:07 behrisch

Sure thing, will update the PR soon.

vijay-jaisankar avatar Jul 23 '22 06:07 vijay-jaisankar

These commits should fix the issue, please check.

vijay-jaisankar avatar Jul 25 '22 16:07 vijay-jaisankar

Thanks, I'll use this code formatting (https://github.com/eclipse/sumo/commit/15445088b530f7b3bd10e6d0dbeb33c9e1a2c348) for the next PRs :)

vijay-jaisankar avatar Jul 29 '22 04:07 vijay-jaisankar

I've since validated my ECA status, the other run error seems to be some kind of texttest installation issue on windows.

vijay-jaisankar avatar Aug 16 '22 02:08 vijay-jaisankar