Fix varargs type mismatch in NLS.bind invocation

[SougandhS]

Replace String[] array with individual Object arguments in NLS.bind calls to resolve type mismatch warnings

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle. Therefore the following files need a version increment:

resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF
team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF
team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF
team/examples/org.eclipse.team.examples.filesystem/pom.xml
ua/org.eclipse.help.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From cb9afc6790e965ddeffaa7c7fe86f22d47e50b92 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sat, 7 Jun 2025 14:45:47 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF b/resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF
index aa042e2f42..33f9280afc 100644
--- a/resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF
+++ b/resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.resources; singleton:=true
-Bundle-Version: 3.22.200.qualifier
+Bundle-Version: 3.22.300.qualifier
 Bundle-Activator: org.eclipse.core.resources.ResourcesPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF
index 3bd12874e5..2282a03326 100644
--- a/team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.team.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.team.ui; singleton:=true
-Bundle-Version: 3.11.100.qualifier
+Bundle-Version: 3.11.200.qualifier
 Bundle-Activator: org.eclipse.team.internal.ui.TeamUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF b/team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF
index 6150136e39..ce8a09414c 100644
--- a/team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF
+++ b/team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.team.examples.filesystem; singleton:=true
-Bundle-Version: 3.7.700.qualifier
+Bundle-Version: 3.7.800.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.team.examples.filesystem,
diff --git a/team/examples/org.eclipse.team.examples.filesystem/pom.xml b/team/examples/org.eclipse.team.examples.filesystem/pom.xml
index 11bb012a6a..867ff93798 100644
--- a/team/examples/org.eclipse.team.examples.filesystem/pom.xml
+++ b/team/examples/org.eclipse.team.examples.filesystem/pom.xml
@@ -18,7 +18,7 @@
     <relativePath>../../</relativePath>
   </parent>
   <artifactId>org.eclipse.team.examples.filesystem</artifactId>
-  <version>3.7.700-SNAPSHOT</version>
+  <version>3.7.800-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
   <build>
   	<plugins>
diff --git a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
index 1218bc2fd5..7593a41764 100644
--- a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %help_system_plugin_name
 Bundle-SymbolicName: org.eclipse.help.ui; singleton:=true
-Bundle-Version: 4.8.100.qualifier
+Bundle-Version: 4.8.200.qualifier
 Bundle-Activator: org.eclipse.help.ui.internal.HelpUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions[bot]]

Test Results

 1 893 files  ±0   1 893 suites  ±0   1h 31m 5s ⏱️ +35s  4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0  13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 234eee70. ± Comparison against base commit 2d1c1e2c.

:recycle: This comment has been updated with latest results.

[SougandhS]

Hi @HannesWell , could you please check this PR when you have some time ?

[SougandhS]

Hi @HannesWell , could you please check this PR when you have some time ?

All binding changes has been handled

[HannesWell]

Thank you @SougandhS for fixing all these warnings. I should have had a broader look at warnings but I have now created a follow-up that avoids these warnings:

• https://github.com/eclipse-equinox/equinox/pull/939

Actually, as mentioned in https://github.com/eclipse-equinox/equinox/pull/936#discussion_r2072648327, I wanted to use/test our automated clean-up job to perform the removal of the unnecessary array creations. I don't want to reject your work just, for that, but I would still like the clean-up job to create a PR first just to compare the result of your work and that job. But it might prolong the review by a few days. But the warnings should be gone sooner.

[SougandhS]

Thank you @SougandhS for fixing all these warnings. I should have had a broader look at warnings but I have now created a follow-up that avoids these warnings:

• Make var-args overload of NLS.bind() generic eclipse-equinox/equinox#939

Actually, as mentioned in eclipse-equinox/equinox#936 (comment), I wanted to use/test our automated clean-up job to perform the removal of the unnecessary array creations. I don't want to reject your work just, for that, but I would still like the clean-up job to create a PR first just to compare the result of your work and that job. But it might prolong the review by a few days. But the warnings should be gone sooner.

Thanks, I’ll keep an eye out for the PR from the cleanup job 👍

[akurtakov]

Would you please rebase this PR? There are conflicts.

[SougandhS]

Would you please rebase this PR? There are conflicts.

Done 👍

[SougandhS]

Thank you @akurtakov