eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Remove 2018 deprecated runtime contenttype extension point

Open vogella opened this issue 1 year ago • 5 comments

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

vogella avatar Nov 27 '24 22:11 vogella

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

HannesWell avatar Nov 27 '24 22:11 HannesWell

This pull request changes some projects for the first time in this development cycle. Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From dae5e5bd99a2041de3a6b5282301fa0fa28ff0b1 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 12 May 2025 06:49:44 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index d7ec81e54a..ed76b75691 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.33.0.qualifier
+Bundle-Version: 3.33.100.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

eclipse-platform-bot avatar Nov 27 '24 22:11 eclipse-platform-bot

Awesome @HannesWell that works. Thank you for the tip

vogella avatar Nov 27 '24 22:11 vogella

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

Will do.

vogella avatar Nov 27 '24 22:11 vogella

Test Results

 1 683 files   -  81   1 683 suites   - 81   1h 41m 34s ⏱️ + 11m 57s  4 228 tests  - 153   4 198 ✅  - 158   24 💤 ±0   6 ❌ + 5  12 684 runs   - 459  12 499 ✅  - 476  167 💤 ±0  18 ❌ +17 

For more details on these failures, see this check.

Results for commit 4991a2f1. ± Comparison against base commit babaec5d.

This pull request removes 153 tests.
AllCompareTests AsyncExecTests ‑ testCancelOnRequeue
AllCompareTests AsyncExecTests ‑ testQueueAdd
AllCompareTests AsyncExecTests ‑ testWorker
AllCompareTests CompareFileRevisionEditorInputTest ‑ testPrepareCompareInputWithNonLocalResourceTypedElements
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptorForTextType_StreamAccessor
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptor_TextType_NotStreamAccessor
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptor_UnknownType
AllCompareTests ContentMergeViewerTest ‑ testFFFX
AllCompareTests ContentMergeViewerTest ‑ testFFTX
AllCompareTests ContentMergeViewerTest ‑ testFFXF
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 27 '24 23:11 github-actions[bot]