eclipse.platform
eclipse.platform copied to clipboard
eclipse-platform
Native file info fragment for Windows on Arm64 (WoA) platform.
The following new fragment for WoA is added to the project to support local file info access using native code:
org.eclipse.core.filesystem.win32.aarch64
To manually build the file info native library for WoA, on a WoA box, run the following commands:
cd resources\bundles\org.eclipse.core.filesystem\natives\win32
make.bat
and the following native library file for WoA is generated and saved in its relevant directory:
resources\bundles\org.eclipse.core.filesystem.win32.aarch64\os\win32\aarch64\localfile_1_0_0.dll
The existing 'make.bat' file mentioned above has been modified to generate correct binary for the current build environment (x64 or aarch64.)
As discussed here.
Thank you @chirontt for this one. But with the numbers shared by @iloveeclipse in https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/577#issuecomment-2107152131 (thanks for that) I think it not worth the effort to have, build and maintain this for now. Of course assuming that the numbers are similar for Windows. Nevertheless I think the removal of obsolete build-scripts and enhancing of the still relevant ones would be good to have.
I agree that @iloveeclipse 's numbers are better than any numbers I could have produced myself. So I'll drop this PR to draft, pending closing it off later if necessary.
Nevertheless I think the removal of obsolete build-scripts and enhancing of the still relevant ones would be good to have.
Not sure whether those small changes would even be needed, but I'll create a separate PR for them if needed.
I inspected the default DosHandler in more detail and since it calls Path.toRealPath(), which is quite expensive on Windows, I fear that the numbers would be worse.
https://github.com/eclipse-platform/eclipse.platform/blob/15c6f845d380536c453491e680884d2e3a9e5c50/resources/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/nio/DosHandler.java#L45
As already mentioned in https://github.com/eclipse-platform/eclipse.platform/pull/1350#issuecomment-2120955068, I think we should evaluate an JNA based implementation as an intermediate solution until we can use FFM in order to avoid more compiled native binaries.
I think we should evaluate an JNA based implementation as an intermediate solution until we can use FFM in order to avoid more compiled native binaries.
Yes, I agree with the JNA route; or perhaps we should start learning about FFM and skip the JNA instead.
I think we should evaluate an JNA based implementation as an intermediate solution until we can use FFM in order to avoid more compiled native binaries.
Yes, I agree with the JNA route; or perhaps we should start learning about FFM and skip the JNA instead.
I would love to skip JNA and would go directly to FFM, but I assume it will take some time until the eclipse-platform requires a Java version with that we can use it. When I had some discussion about using preview-features not everybody agreed.
Nevertheless I think the removal of obsolete build-scripts and enhancing of the still relevant ones would be good to have.
Not sure whether those small changes would even be needed, but I'll create a separate PR for them if needed.
I just created a PR to the clean-up all the native code and its scripts for the Windows native filesystem access: https://github.com/eclipse-platform/eclipse.platform/pull/1416
Just created https://github.com/eclipse-platform/eclipse.platform/pull/1422 to speed up the File-System access without native code. From the numbers I obtained in a preliminary benchmark having a native fragment would not be necessary anymore. But lets await the final results.
Just created #1422 to speed up the File-System access without native code. From the numbers I obtained in a preliminary benchmark having a native fragment would not be necessary anymore. But lets await the final results.
Just run the benchmark on the working implementation and it showed that the enhanced DosHandler is on par with the native implementation: https://github.com/eclipse-platform/eclipse.platform/pull/1422#issuecomment-2184161944
If that is submitted I don't think we need a native implementation for Windows on ARM.
Nevertheless I think the removal of obsolete build-scripts and enhancing of the still relevant ones would be good to have.
Not sure whether those small changes would even be needed, but I'll create a separate PR for them if needed.
FYI, I did that as part of https://github.com/eclipse-platform/eclipse.platform/pull/1416.
Now that https://github.com/eclipse-platform/eclipse.platform/pull/1422 is submitted, this should not be necessary anymore.
In fact I have just proposed to remove the JNI based LocalFileHandler for all supported architectures supported on Windows via https://github.com/eclipse-platform/eclipse.platform/pull/1476.
With that I think this is obsolete, but nevertheless thank you for this.
Btw. it would be nice to know if #1422 makes a noticeable difference with Windows on ARM? Can you download the upcoming I-build and report back?
I've used the Eclipse SDK for Windows on Arm64 from the latest I-build, but I don't notice much difference compared to other previous builds.