eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

LogView: Date column should be more fine grained

Open chrisrueger opened this issue 6 months ago • 5 comments

  • and show yyyy-MM-dd HH:mm:ss.SSS instead of just minute precision
  • this is useful where you want to see the exact time of log events in cases where seconds or even milliseconds matter

Shows this:

image

instead of

image

chrisrueger avatar May 08 '25 18:05 chrisrueger

This sounds like a reasonable thing to do.

BeckerWdf avatar May 09 '25 05:05 BeckerWdf

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 41m 22s ⏱️ + 7m 46s  7 925 tests ±0   7 697 ✅ +1  228 💤 ±0  0 ❌  - 1  23 324 runs   - 4  22 578 ✅  - 3  746 💤 ±0  0 ❌  - 1 

Results for commit 338d18cd. ± Comparison against base commit 6260295e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '25 06:05 github-actions[bot]

Does anyone from the other committers have any objections to merging this change?

BeckerWdf avatar May 09 '25 06:05 BeckerWdf

No objections, I really like this change.

Just some technical part: In line 109, we could now do

-return dateFormat.format(entry.getDate());
+return entry.getFormattedDate();

That does internal caching of the log date string and might optimize things a bit.

Then, we could also give org.eclipse.ui.internal.views.log.LogSession a getFormattedDate() method that returns this.

Then get rid off the additional org.eclipse.ui.internal.views.log.LogViewLabelProvider.dateFormat in the label provider.

sratz avatar May 09 '25 09:05 sratz

Thanks @sratz . Like this https://github.com/eclipse-platform/eclipse.platform.ui/pull/2963/commits/7e88f9f58176dee39a20b39a5f2320c3315dc06b ?

Once approved, I can squash the commits at the end.

Update: Here is a screenshot grouped by Session, to see the new LogSession.getFormattedDate()

image

chrisrueger avatar May 09 '25 11:05 chrisrueger

@chrisrueger: Can you sign the ECA with Eclipse? Then we can get this in 2025-09 M1. See https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#setting-up-your-eclipse-and-github-account

sratz avatar Jun 06 '25 09:06 sratz

This pull request changes some projects for the first time in this development cycle. Therefore the following files need a version increment:

bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From f0bfd2cc0c4ea4f78151d199f83e814bf1bc8493 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 6 Jun 2025 09:47:50 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
index 6849404e49..0f5e26f97f 100644
--- a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.ui.views.log;singleton:=true
-Bundle-Version: 1.4.800.qualifier
+Bundle-Version: 1.4.900.qualifier
 Bundle-Activator: org.eclipse.ui.internal.views.log.Activator
 Bundle-Vendor: %provider-name
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

eclipse-platform-bot avatar Jun 06 '25 09:06 eclipse-platform-bot

@chrisrueger: Can you sign the ECA with Eclipse? Then we can get this in 2025-09 M1. See https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#setting-up-your-eclipse-and-github-account

@sratz Hmm I actually have. This is not my first contribution. Is Eclipse.org having problems? I also cannot log in to my account at the moment. I remember there were issues in the past too, when I contributed something together with @laeubi

chrisrueger avatar Jun 06 '25 09:06 chrisrueger

@chrisrueger: Can you sign the ECA with Eclipse? Then we can get this in 2025-09 M1. See https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#setting-up-your-eclipse-and-github-account

@sratz Hmm I actually have. This is not my first contribution. Is Eclipse.org having problems? I also cannot log in to my account at the moment. I remember there were issues in the past too, when I contributed something together with @laeubi

Hmm, yes. I can't even log in to eclipse.org currently.

sratz avatar Jun 06 '25 10:06 sratz

Please add all failing ECA cases to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6246 . As it's sporadic, let's hope that with some instance they will manage to figure what actually happens.

akurtakov avatar Jun 06 '25 10:06 akurtakov