Newer Workspace Version popup dialog ui alignment changes.

[deepika-u]

Before the fix the dialog used to show up as

After the fix the dialog now is showed up as

This popup dialog basically comes when a workspace for example already used/edited/saved in 4.36 and now attempted to open with an older eclipse say 4.35 or lower, this pop up shows up.

Change 1 : check box is aligned. Change 2 : Button bar is center aligned.

Here we are changing the behavior of the current popup dialog leaving the original dialog alignments as-is.

[BeckerWdf]

I don't think that center-aligning the button brings an advantage.

[deepika-u]

I don't think that center-aligning the button brings an advantage.

Thanks for your opinion, will be reverting the 2nd change. Updated as per review comments.

[tomaswolf]

Yes, don't center the buttons. If at all that would be done in #2929. (And this dialog here might make a good simple test case to check that whatever is done in #2929 doesn't mess up things.)

[github-actions[bot]]

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 35m 8s ⏱️ -31s  7 918 tests ±0   7 690 ✅ +2  228 💤 ±0  0 ❌  - 2  23 841 runs  ±0  23 093 ✅ +2  748 💤 ±0  0 ❌  - 2 

Results for commit 399983b5. ± Comparison against base commit 912fadfd.

:recycle: This comment has been updated with latest results.

[deepika-u]

Yes, don't center the buttons. If at all that would be done in #2929. (And this dialog here might make a good simple test case to check that whatever is done in #2929 doesn't mess up things.)

Now after the fix, only the check box line is aligned and the buttons will continue to right align as earlier. From understanding with #2929 and its respective fix only the warning section will be updated but nothing to do with such kind of check box settings given for user to opt. Please correct me if i am not mistaken.

Now after this fix only the 2nd line is aligned changing the behavior of the current popup dialog leaving the original dialog alignments as-is.

[deepika-u]

@BeckerWdf : can you check this when you have some time please?

[deepika-u]

@tomaswolf @BeckerWdf Do you have any further suggestions regarding this fix?

Here as per the suggestions buttons are right aligned. Warning is still left aligned. Only the check box part is aligned. Are we good?

[BeckerWdf]

Aligning the text and the checkbox is fine for me. I know this dialog a lot. I never felt it was wrong. But I think having the checkbox left aligned (with the icon) indeed is not correct.

[deepika-u]

@BeckerWdf Do you have any other way / suggestion to implement this?

[deepika-u]

@BeckerWdf : Any other thoughts please?

[deepika-u]

@BeckerWdf Sorry to bother you again, do you have any other suggestions on this please?