eclipse.platform.swt
eclipse.platform.swt copied to clipboard
eclipse-platform
#924 [Win32] Possible ERROR_GRAPHIC_DISPOSED error during painting
This should cover the case that BeginBufferedPaint might fail.
Test Results
483 files ±0 483 suites ±0 8m 22s ⏱️ -17s 4 095 tests ±0 4 085 ✅ ±0 7 💤 ±0 3 ❌ ±0 16 173 runs ±0 16 080 ✅ ±0 90 💤 ±0 3 ❌ ±0
For more details on these failures, see this check.
Results for commit 25047142. ± Comparison against base commit 2ce8542b.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can somebody please merge this request? I don't think that the failing GTK tests are caused by this patch.
So this PR fixes https://github.com/eclipse-platform/eclipse.platform.swt/issues/924 ?
I am not an expert on that topic and even do no work on windows. So somebody else should have a look at it.
In general, the change looks sound to me. I am just wondering whether it is necessary and thus whether we should merge this change now. We are already past M3 and even though I would consider the risk of the change as low in general, at the same the affected code is quite crucial. The issue does not seem to be critical: the report has been made a year ago and no one else complained so far. So would it be sufficient to target this for 2025-03 M1? Then we have the whole three months of 2025-03 development for implicit testing by developers using Windows.
Would someone be brave enough to commit to master? Why does the Linux build fail? Shouldn't be caused by this PR.
Would someone be brave enough to commit to master? Why does the Linux build fail? Shouldn't be caused by this PR.
Yes, I've just rebased the branch onto master. Linux build failures are existing and documented here: #1564 I'm just curious about the reported new Maven issues, which is why I retriggered the Jenkins build.