eclipse.platform.releng.aggregator
eclipse.platform.releng.aggregator copied to clipboard
eclipse-platform
[Builds] Remove elements unnecessary with the new version-bump workflow
With the new reusable workflow for automated version increments in pull-requests, introduced with https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/2352, it is not necessary anymore to bump versions in advance during release preparation or the enable bumping if the property 'compare-version-with-baselines.skip' is set to false. Everything now happens automatically and these elements can therefore be removed.
Removing these elements avoids partly duplicated configuration and generally reduced the amount of configuration.
As thenew workflow is not yet setup on this repo, this one can not be pushed, right?
As thenew workflow is not yet setup on this repo, this one can not be pushed, right?
This repository is not really the problem since the removed elements are (hardly) used here, but we should await until it's active in all other (active) SDK repositories. And while JDT should only be a matter of committer time, Equinox and SWT seem to need more adjustments and might take longer.
Landing this part in.
To add some context, why this is important now: The updateRelease workflow currently suffers the same problems like the workflow for automated version increment, which is why these two repos don't have it yet:
- https://github.com/eclipse-equinox/equinox/pull/678
- https://github.com/eclipse-platform/eclipse.platform.swt/pull/1491
With this being submitted, Equinox and SWT still don't get the version-bumps on first change in the dev-cycle, but at least changing the parent-pom version should be possible now.
For Equinox and SWT the following PRs could now be created, after renaming the existing 4.35 milestone creating a new one with the same original data and afterwards deleting the new one and restoring the name of the original one:
- https://github.com/eclipse-equinox/equinox/pull/701
- https://github.com/eclipse-platform/eclipse.platform.swt/pull/1614