openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

criu_pingPerf_testCreateRestoreImageAndPushToRegistry_ubi9_0 FAILED CRIUSupport(imageDir) constructor is deprecated, please use CRIUSupport.getCRIUSupport() and setImageDir(imageDir)

Open JasonFengJ9 opened this issue 8 months ago • 7 comments

Failure link

From internal Test_openjdk11_j9_dev.external_s390x_linux_imageUpload (rhel8s390x-rt-1)

openjdk version "11.0.27" 2025-04-15
IBM Semeru Runtime Open Edition 11.0.27.0-m1 (build 11.0.27+4)
Eclipse OpenJ9 VM 11.0.27.0-m1 (build v0.51.0-release-70f26c921d, JRE 11 Linux s390x-64-Bit Compressed References 20250311_1210 (JIT enabled, AOT enabled)
OpenJ9   - 70f26c921d
OMR      - 20241356e
JCL      - f0f63c71c3 based on jdk-11.0.27+4)

Rerun in Grinder - Change TARGET to run only the failed test targets

Optional info

Failure output (captured from console output)

[2025-03-13T16:52:28.543Z] variation: NoOptions
[2025-03-13T16:52:28.543Z] JVM_OPTIONS:  

[2025-03-13T17:00:43.049Z] [err] WARNING: CRIUSupport(imageDir) constructor is deprecated, please use CRIUSupport.getCRIUSupport() and setImageDir(imageDir)
[2025-03-13T17:00:43.049Z] -----------------------------------
[2025-03-13T17:00:43.049Z] criu_pingPerf_testCreateRestoreImageAndPushToRegistry_ubi9_0_FAILED

The test code is required to adopt

  • https://github.com/eclipse-openj9/openj9/pull/21319

FYI @LongyuZhang @tajila

JasonFengJ9 avatar Mar 18 '25 18:03 JasonFengJ9

@llxia fyi

pshipton avatar Mar 18 '25 18:03 pshipton

[2025-03-13T17:00:43.049Z] [err] WARNING: CRIUSupport(imageDir) constructor is deprecated, please use CRIUSupport.getCRIUSupport() and setImageDir(imageDir)

CRIUSupport(imageDir) constructor will be restored during the transition period.

JasonFengJ9 avatar Mar 19 '25 14:03 JasonFengJ9

As discussed in the CRIU meeting, the constructor will be changed back to non-deprecated for this release, so I think we can close this issue. FYI @tajila @llxia

LongyuZhang avatar Apr 01 '25 19:04 LongyuZhang

My understanding is there is an action to update the tests. I'm going to reopen this and move it forward.

pshipton avatar Apr 01 '25 19:04 pshipton

Jason said: Liberty team reported a similar test issue, hence the original constructor API was restored, there is no plan to remove it now. So it is optional to change the test, or at low priority.

Removing the milestone.

pshipton avatar Apr 01 '25 19:04 pshipton

We should still update the API. We will be removing the original one in a future release once Liberty has made the switch.

tajila avatar Apr 01 '25 19:04 tajila

Discussed with @JasonFengJ9 , our openj9 side has completed the modifications, the error seems to be Open Liberty 25.0.0.6-beta/wlp-1.0.101.cl250520250504-1901 is still using the deprecated api, test link:

15:45:54  [AUDIT   ] CWWKZ0001I: Application pingperf started in 0.755 seconds.
15:45:54  [AUDIT   ] CWWKC0451I: A server checkpoint "afterAppStart" was requested. When the checkpoint completes, the server stops.
15:45:54  [err] WARNING: CRIUSupport(imageDir) constructor is deprecated, please use CRIUSupport.getCRIUSupport() and setImageDir(imageDir)

LongyuZhang avatar May 22 '25 19:05 LongyuZhang