openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-openj9

Inline checkcast of references to elements of j/l/O arrays on x86

Open 0xdaryl opened this issue 9 months ago • 7 comments

Casting to arrays was considered unlikely and therefore not fast-pathed in JITed code. However, checkcasts of non-primitive references to j/l/O arrays should always succeed and can be easily checked for without calling a helper.

0xdaryl avatar Mar 03 '25 16:03 0xdaryl

Jenkins test sanity.functional,sanity.openjdk xlinux,win,xmac jdk21

0xdaryl avatar Mar 03 '25 16:03 0xdaryl

Bah, forgot the OMR dependency.

0xdaryl avatar Mar 03 '25 16:03 0xdaryl

Jenkins test sanity.functional,sanity.openjdk xlinux,win,xmac jdk21 depends eclipse-omr/omr#7676

0xdaryl avatar Mar 03 '25 16:03 0xdaryl

Jenkins test sanity.functional,sanity.openjdk xlinux,win,xmac jdk21

0xdaryl avatar Mar 05 '25 02:03 0xdaryl

@vijaysun-omr

0xdaryl avatar May 30 '25 16:05 0xdaryl

Jenkins test sanity.functional,sanity.openjdk xlinux,win,xmac jdk21

0xdaryl avatar Jun 04 '25 23:06 0xdaryl

Un-WIPing

0xdaryl avatar Jun 05 '25 15:06 0xdaryl

Friendly poke on the status of this PR...

vijaysun-omr avatar Jun 24 '25 16:06 vijaysun-omr

If you are okay delivering the instanceof "extension" in a separate PR, I can merge this one. I just want to make sure that there is an issue or some other reminder for us to get to that work in a certain manner.

vijaysun-omr avatar Jul 03 '25 13:07 vijaysun-omr

Yes, I'll fix instanceof in a separate PR. It does not need to hold this PR up for checkcast.

0xdaryl avatar Jul 03 '25 13:07 0xdaryl

Tests have passed. Will merge it now since the remaining work will be done in a separate PR.

vijaysun-omr avatar Jul 03 '25 13:07 vijaysun-omr