openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Set log file in TR_Debug at client

Open cjjdespres opened this issue 1 year ago • 1 comments

When a client recompiles a method locally following a remote compilation (enabled with the enableJITServerFollowRemoteCompileWithLocalCompile option) it must set up a local log file for compilation traces if necessary. Previously, it would only set this log file explicitly in the TR::Compilation object itself; the _file in the TR_Debug object for the compilation would not be set. Since the TR_Debug would have been created already during the prior remote compilation with a NULL _file, this had the effect of suppressing the compilation traces coming from systems that used that _file for output and not the _logFile in the TR::Compilation itself.

The file in the TR_Debug object for the compilation is now set explicitly.

cjjdespres avatar Oct 17 '24 15:10 cjjdespres

Attn @mpirvu

cjjdespres avatar Oct 17 '24 15:10 cjjdespres

jenkins test sanity xlinuxjit,zlinuxjit jdk17

mpirvu avatar Oct 21 '24 17:10 mpirvu

xlinuxjit had a failure in jdk_util_0

16:00:16  Timeout signalled after 960 seconds
16:00:16  STDERR:
16:00:16  WARNING: Using incubator modules: jdk.incubator.foreign
16:00:16  JVMDUMP034I User requested System dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_x86-64_linux_jit_Personal_testList_2/aqa-tests/TKG/output_17295366671253/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest/core.20241021.160001.12199.0001.dmp' through com.ibm.jvm.Dump.systemDumpToFile
16:00:16  JVMDUMP010I System dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_x86-64_linux_jit_Personal_testList_2/aqa-tests/TKG/output_17295366671253/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest/core.20241021.160001.12199.0001.dmp
16:00:16  JVMDUMP034I User requested Java dump using '/home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_x86-64_linux_jit_Personal_testList_2/aqa-tests/TKG/output_17295366671253/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest/javacore.20241021.160006.12199.0002.txt' through com.ibm.jvm.Dump.javaDumpToFile
16:00:16  JVMDUMP010I Java dump written to /home/jenkins/workspace/Test_openjdk17_j9_sanity.openjdk_x86-64_linux_jit_Personal_testList_2/aqa-tests/TKG/output_17295366671253/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest/javacore.20241021.160006.12199.0002.txt


16:03:59  FAILED test targets:
16:03:59  	jdk_util_0 - Test results: passed: 906; error: 1 
16:03:59  		Failed test cases: 
16:03:59  			TEST: java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest.java

The changes from this PR cannot be responsible for this failure, hence merging.

mpirvu avatar Oct 22 '24 14:10 mpirvu