openj9
openj9 copied to clipboard
Rename Preload attribute to LoadableDescriptors
Fixes: https://github.com/eclipse-openj9/openj9/issues/19611
I tried to split commits as follows for easier reviewing:
- Test changes
- VM logic changes
- VM renaming and formatting
Please address the line endings check failure.
Jenkins test sanity aarch64_linux,aarch64_linux_vt_standard jdknext
Updates are required to https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes before that repository will compile with the current content of https://github.com/eclipse-openj9/openj9:
[2024-10-17T16:51:51.110Z] /home/jenkins/workspace/Build_JDKnext_aarch64_linux_vt_standard_Personal/build/linux-aarch64-server-release/support/j9jcl/jdk.management/share/classes/com/ibm/lang/management/internal/PlatformMBeanProvider.java:40: error: cannot find symbol
[2024-10-17T16:51:51.110Z] import com.sun.management.internal.VirtualThreadSchedulerImpls;
[2024-10-17T16:51:51.110Z] ^
[2024-10-17T16:51:51.110Z] symbol: class VirtualThreadSchedulerImpls
[2024-10-17T16:51:51.110Z] location: package com.sun.management.internal
[2024-10-17T16:51:51.110Z] /home/jenkins/workspace/Build_JDKnext_aarch64_linux_vt_standard_Personal/build/linux-aarch64-server-release/support/j9jcl/jdk.management/share/classes/com/ibm/lang/management/internal/PlatformMBeanProvider.java:41: error: package jdk.management does not exist
[2024-10-17T16:51:51.110Z] import jdk.management.VirtualThreadSchedulerMXBean;
[2024-10-17T16:51:51.110Z] ^
[2024-10-17T16:51:51.110Z] /home/jenkins/workspace/Build_JDKnext_aarch64_linux_vt_standard_Personal/build/linux-aarch64-server-release/support/j9jcl/jdk.management/share/classes/com/ibm/lang/management/internal/PlatformMBeanProvider.java:114: error: cannot find symbol
[2024-10-17T16:51:51.110Z] .addInterface(VirtualThreadSchedulerMXBean.class)
[2024-10-17T16:51:51.110Z] ^
[2024-10-17T16:51:51.110Z] symbol: class VirtualThreadSchedulerMXBean
[2024-10-17T16:51:51.110Z] location: class PlatformMBeanProvider
[2024-10-17T16:51:51.110Z] /home/jenkins/workspace/Build_JDKnext_aarch64_linux_vt_standard_Personal/build/linux-aarch64-server-release/support/j9jcl/jdk.management/share/classes/com/ibm/lang/management/internal/PlatformMBeanProvider.java:113: error: cannot find symbol
[2024-10-17T16:51:51.110Z] ComponentBuilder.create("jdk.management:type=VirtualThreadScheduler", VirtualThreadSchedulerImpls.create()) //$NON-NLS-1$
[2024-10-17T16:51:51.110Z] ^
[2024-10-17T16:51:51.110Z] symbol: variable VirtualThreadSchedulerImpls
[2024-10-17T16:51:51.110Z] location: class PlatformMBeanProvider
[2024-10-17T16:51:51.110Z] 4 errors
I created https://github.com/eclipse-openj9/openj9/pull/20377 which should unblock this.
Jenkins test sanity aarch64_linux_vt_standard jdknext
There are many failures like this:
FAILED CONFIGURATION: @BeforeMethod setUp
java.lang.InternalError: java.lang.IllegalAccessException: static final field has no write access: jdk.internal.misc.Unsafe.theUnsafe/jdk.internal.misc.Unsafe/putStatic, from class java.lang.Object (module java.base)
at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.newFieldAccessor(MethodHandleAccessorFactory.java:207)
at java.base/jdk.internal.reflect.ReflectionFactory.newFieldAccessor(ReflectionFactory.java:144)
at java.base/java.lang.reflect.Field.acquireOverrideFieldAccessor(Field.java:1212)
at java.base/java.lang.reflect.Field.getOverrideFieldAccessor(Field.java:1181)
at java.base/java.lang.reflect.Field.get(Field.java:454)
at org.openj9.test.unsafe.UnsafeTestBase.getUnsafeInstance(UnsafeTestBase.java:120)
at org.openj9.test.unsafe.UnsafeTestBase.setUp(UnsafeTestBase.java:562)
[...]
Caused by: java.lang.IllegalAccessException: static final field has no write access: jdk.internal.misc.Unsafe.theUnsafe/jdk.internal.misc.Unsafe/putStatic, from class java.lang.Object (module java.base)
at java.base/java.lang.invoke.MemberName.makeAccessException(MemberName.java:913)
at java.base/java.lang.invoke.MethodHandles$Lookup.unreflectField(MethodHandles.java:3608)
at java.base/java.lang.invoke.MethodHandles$Lookup.unreflectSetter(MethodHandles.java:3599)
at java.base/java.lang.invoke.MethodHandleImpl$1.unreflectField(MethodHandleImpl.java:1621)
at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.newFieldAccessor(MethodHandleAccessorFactory.java:185)
... 31 more
Those failures are related to https://github.com/eclipse-openj9/openj9/issues/20372
Do you have more review comments on this ? @keithc-ca
Do you have more review comments on this?
No more comments other than to say I'd be happier if we didn't have to ignore test failures, but I'll defer to you, @hangshao0.
Jenkins test sanity.functional,extended alinuxval jdknext