openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Remove requirement for consistent page size in SCC

Open hangshao0 opened this issue 1 year ago • 3 comments

The page level operation in SCC are msync and mprotect. msync is only used on z/OS, we can always do msync if we can have a valid _osPageSize. For mprotect, it is turned off if the SCC is readonly. If the data is not paged aligned anymore, mprotect should \also be turned off. There is no need to force consistent memory page size anymore.

Fixes #19968

hangshao0 avatar Aug 07 '24 14:08 hangshao0

Any idea why the cache isn't mprotected when read-only? Except on z/OS, it seems the entire read-only cache should be mprotected.

Pls add a test flag so page size differences can be automatically tested.

pshipton avatar Aug 13 '24 19:08 pshipton

I'm wondering if the two page sizes should be output in the javacore and printstats output, for easier diagnostics.

pshipton avatar Aug 13 '24 19:08 pshipton

Any idea why the cache isn't mprotected when read-only?

There are open readonly, so they are memory protected.

Discussed with Peter in person, I will add a test option and test cases that takes fake memory page size. We can add the page size information in the printTopLayerstats and javacore.

hangshao0 avatar Aug 13 '24 20:08 hangshao0

@hangshao0 Any update on this?

tajila avatar Sep 04 '24 13:09 tajila

Any update on this?

Currently working other item having higher priority. I will come back working on this shortly.

hangshao0 avatar Sep 04 '24 15:09 hangshao0

@pshipton Please take a look

tajila avatar Sep 17 '24 13:09 tajila

Tested internally.

pshipton avatar Sep 17 '24 20:09 pshipton