openj9
openj9 copied to clipboard
eclipse-openj9
Add FFI Upcall support on z/OS for primitives
Add @zl-wang for review in the case of generic issues based on the initial design for thunk.
@dchopra001 going to take a look at the changes in details, but a quick question, would it be possible (and simpler as well) to common some of the instruction generation routine we have here and in https://github.com/eclipse-openj9/openj9/blob/master/runtime/vm/xz64/UpcallThunkGen.cpp ?
New header added here: https://github.com/eclipse-openj9/openj9/pull/19701/commits/e1947c2b216cd5d2e081d8b0831bba3001aa7c9c.
Adding the tests I used to verify correctness. This should provide confidence that the feature is complete. UpcallMHWithPrimTests.java.txt
I will do complete manual testing using the jtreg + jck + openj9 functional tests once the structs PR is open (after this is merged). A lot of the tests are mixed with structs and primitives, so it's a bit tedious to do the testing without the struct changes in their final state.
@dchopra001 : Line Ending check is flagging the following -- Can you double check?
| runtime/vm/mz64/UpcallThunkGen.cpp:208: trailing whitespace.
@dchopra001 : Line Ending check is flagging the following -- Can you double check?
The line endings check has passed now.
@joransiu If you have no more review comments, then would you be able to approve and launch the PR testing?
Line endings check with stderr: fatal: unable to access 'https://github.com/eclipse-openj9/openj9.git/': gnutls_handshake() failed: The TLS connection was non-properly terminated..
I'm not sure how to restart it.