x86: Implement crc32c helper function

[BradleyWood]

[BradleyWood]

@0xdaryl Please check the changes.

In addition to your comments, I have ifdef'd this code to 64-bit only with no 32-bit implementation.

As a reminder, this depends on eclipse/omr#7342

[0xdaryl]

I have ifdef'd this code to 64-bit only with no 32-bit implementation.

Your OMR PR adds a 32-bit helper which isn't initialized by this PR.

[BradleyWood]

I have ifdef'd this code to 64-bit only with no 32-bit implementation.

Your OMR PR adds a 32-bit helper which isn't initialized by this PR.

It does not compile without a placeholder.

Edit: Does j9 need to care about that if it doesn't implement it?

[0xdaryl]

Sorry, what doesn't compile? It should build if the 32-bit helper wasn't added in OMR.

[BradleyWood]

Nevermind that comment, I removed the 32-bit declaration in omr

[0xdaryl]

Other than fixing the formatting, are there any other changes pending?

[BradleyWood]

Other than fixing the formatting, are there any other changes pending?

I don't think so

[0xdaryl]

Jenkins test sanity xlinux,win,xmac jdk17

[0xdaryl]

Please see CI build failure on X86Codert.nasm.

[BradleyWood]

@0xdaryl You can try this change. I'm not sure it will work because I don't know the exact assembler version used in jenkins. Can you make sure this PR doesn't break 32-bit builds?

[0xdaryl]

Jenkins test sanity xlinux,win,xmac jdk17

[0xdaryl]

Can you make sure this PR doesn't break 32-bit builds?

~~This is something you can run on the internal axxon farm with SDK 8.~~

Actually, nm. You have the assembler function ifdef'd out for 32-bit

[0xdaryl]

Jenkins test sanity xlinux,win,xmac jdk21

[0xdaryl]

Jenkins test sanity xlinux jdk21

[BradleyWood]

Rebased (no changes)