openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

[FFI/JDK22] Pass the heap segments to native in downcall

Open ChengJin01 opened this issue 1 year ago • 3 comments

The changes aim to pass the heap arguments to native when the linker option intended for the critical downcall is specified.

Fixes: #18939

Note: The feature implemented in this PR is specified in JEP454/JDK22 at https://github.com/eclipse-openj9/openj9/issues/17872 .

Signed-off-by: ChengJin01 [email protected]

ChengJin01 avatar Feb 09 '24 05:02 ChengJin01

The PR has been verified with the internal & OpenJ9 test suites, including the Jtreg test suite (related to the heap arguments) for JDK22 at https://github.com/ibmruntimes/openj9-openjdk-jdk22/tree/master/test/jdk/java/foreign/critical: https://github.com/ibmruntimes/openj9-openjdk-jdk22/blob/master/test/jdk/java/foreign/critical/TestCritical.java https://github.com/ibmruntimes/openj9-openjdk-jdk22/blob/master/test/jdk/java/foreign/critical/TestCriticalUpcall.java

ChengJin01 avatar Feb 09 '24 05:02 ChengJin01

Reviewer: @tajila FYI: @keithc-ca, @pshipton

ChengJin01 avatar Feb 09 '24 05:02 ChengJin01

@amicic FYI

dmitripivkine avatar Feb 14 '24 20:02 dmitripivkine

Jenkins test sanity amac jdk21,jdk22

keithc-ca avatar Feb 21 '24 16:02 keithc-ca

@tajila Could you please approve this?

keithc-ca avatar Feb 21 '24 18:02 keithc-ca

This and https://github.com/eclipse-openj9/openj9/pull/19002 need to be double delivered to the v0.44.0-release branch.

pshipton avatar Feb 23 '24 19:02 pshipton

This and #19002 need to be double delivered to the v0.44.0-release branch.

The PR is created at https://github.com/eclipse-openj9/openj9/pull/19008.

ChengJin01 avatar Feb 23 '24 21:02 ChengJin01