openj9
openj9 copied to clipboard
Clean up GC_TLH_PREFETCH_FTA flag settings in cmake files
This commit removes redundant OMR_GC_TLH_PREFETCH_FTA lines from cmake files for some platforms. OMR_GC_TLH_PREFETCH_FTA is automatically defined in omrcfg.h during the build depending on J9VM_GC_TLH_PREFETCH_FTA value.
Jenkins test sanity all jdk17
See Issue #18870 for the background information.
Jenkins test sanity xlinux,xmac jdk17
Jenkins line endings check
Jenkins test sanity plinux,win,xlinux,xmac jdk17
This PR does not change the flag settings on any platform. OMR_GC_TLH_PREFETCH_FTA in cmake files is useless.
Jenkins test sanity xmac jdk17
Re-running xmac test as it failed with the following message:
fatal: unable to access 'https://github.com/adoptium/aqa-tests.git/': gnutls_handshake() failed: The TLS connection was non-properly terminated.
Jenkins test sanity xlinux jdk17
Re-running xlinux test as it failed in cmdLineTester_criu_nonPortableRestore_5 with the following message:
FAILED: testTimeCompensation() preCheckpoint timer delayed 4s elapsedMillisTime (4001ms) should NOT be less than minElapsedMillisTime (6000ms)
It looks similar to Issue #18471. Assuming it is not a failure caused by this PR.
Jenkins test sanity win jdk17
Re-runnning Windows test. The previous job failed due to timeout, waiting too long in the queue.
Summary:
- x86 platforms:
J9VM_GC_TLH_PREFETCH_FTAis ON. Remove the unusedOMR_GC_TLH_PREFETCH_FTAline. - linux_ppc-64_le:
J9VM_GC_TLH_PREFETCH_FTAis ON. Remove the contradicting and unusedOMR_GC_TLH_PREFETCH_FTAline. - zos_390-64:
J9VM_GC_TLH_PREFETCH_FTAis OFF. Remove the unusedOMR_GC_TLH_PREFETCH_FTAline.
Please note GC part of the code rely on OMR_GC_TLH_PREFETCH_FTA to be set properly.
@dmitripivkine OMR_GC_TLH_PREFETCH_FTA is set properly in omrcfg.h based on J9VM_GC_TLH_PREFETCH_FTA value, as stated in the commit message. The OMR_GC_TLH_PREFETCH_FTA lines in .cmake files are ignored, and it is safe to remove those lines.
j9vm_shadowed_option() in runtime/cmake/options.cmake does the work:
https://github.com/eclipse-openj9/openj9/blob/8ce1cab560f02c33cb3cc38438d9c67600281568/runtime/cmake/options.cmake#L25-L30
https://github.com/eclipse-openj9/openj9/blob/8ce1cab560f02c33cb3cc38438d9c67600281568/runtime/cmake/options.cmake#L74