openj9
openj9 copied to clipboard
WIP: Add checkExternalDecimal API
Marking this as WIP as I need to update getExternalByteCounts call sites to use the new ExternalDecimalSignLocation enum.
cc: @joransiu @r30shah
launched a personal build to test my changes
The test build passed without any failures. https://github.com/eclipse-openj9/openj9-systemtest/pull/152#issuecomment-1895837800. @r30shah this is ready for review.
@r30shah this is ready for an other review.
Launched personal build to verify changes. I'll remove WIP tag once I have verified the changes.
@VermaSh What is the order for the changes to go? I would assume this API need to go first and than https://github.com/eclipse-openj9/openj9-systemtest/pull/152 right ?
Yup, this needs to go ahead of https://github.com/eclipse-openj9/openj9-systemtest/pull/152. Also, I have updated the PR with your suggestions.
jenkins test sanity all jdk8,jdk11,jdk17
@VermaSh Can you verify the failures seen on x86 and aarch64?
@r30shah x86 failures were criu related and arm failure was due to a time out.
jenkins test sanity xlinux jdk11,jdk17
aarch64 cmdLineTester_getPid_0_FAILED test failure doesn't seem to be related. Here's the issue investigating same failure on other platforms.
jenkins test sanity alinux64 jdk17
Thanks @VermaSh for triaging these failures. I have launched last one that failed. Will merge the change once the build finishes.
All test passes. Merging the changes for DAA API