openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

WIP: Add checkExternalDecimal API

Open VermaSh opened this issue 2 years ago • 5 comments

VermaSh avatar Oct 12 '23 13:10 VermaSh

Marking this as WIP as I need to update getExternalByteCounts call sites to use the new ExternalDecimalSignLocation enum. cc: @joransiu @r30shah

VermaSh avatar Oct 12 '23 13:10 VermaSh

launched a personal build to test my changes

VermaSh avatar Jan 10 '24 17:01 VermaSh

The test build passed without any failures. https://github.com/eclipse-openj9/openj9-systemtest/pull/152#issuecomment-1895837800. @r30shah this is ready for review.

VermaSh avatar Jan 17 '24 13:01 VermaSh

@r30shah this is ready for an other review.

VermaSh avatar Jan 25 '24 20:01 VermaSh

Launched personal build to verify changes. I'll remove WIP tag once I have verified the changes.

VermaSh avatar Feb 06 '24 21:02 VermaSh

@VermaSh What is the order for the changes to go? I would assume this API need to go first and than https://github.com/eclipse-openj9/openj9-systemtest/pull/152 right ?

r30shah avatar Mar 28 '24 14:03 r30shah

Yup, this needs to go ahead of https://github.com/eclipse-openj9/openj9-systemtest/pull/152. Also, I have updated the PR with your suggestions.

VermaSh avatar Apr 03 '24 14:04 VermaSh

jenkins test sanity all jdk8,jdk11,jdk17

r30shah avatar Apr 03 '24 21:04 r30shah

@VermaSh Can you verify the failures seen on x86 and aarch64?

r30shah avatar Apr 05 '24 19:04 r30shah

@r30shah x86 failures were criu related and arm failure was due to a time out.

VermaSh avatar Apr 08 '24 19:04 VermaSh

jenkins test sanity xlinux jdk11,jdk17

r30shah avatar Apr 08 '24 19:04 r30shah

aarch64 cmdLineTester_getPid_0_FAILED test failure doesn't seem to be related. Here's the issue investigating same failure on other platforms.

VermaSh avatar Apr 09 '24 13:04 VermaSh

jenkins test sanity alinux64 jdk17

r30shah avatar Apr 09 '24 14:04 r30shah

Thanks @VermaSh for triaging these failures. I have launched last one that failed. Will merge the change once the build finishes.

r30shah avatar Apr 09 '24 14:04 r30shah

All test passes. Merging the changes for DAA API

r30shah avatar Apr 09 '24 20:04 r30shah