mat icon indicating copy to clipboard operation
mat copied to clipboard

Proposed patch to add report extension to Overview pane

Open eclipsewebmaster opened this issue 1 year ago • 4 comments
trafficstars

| --- | --- | | Bugzilla Link | 361695 | | Status | NEW | | Importance | P3 enhancement | | Reported | Oct 21, 2011 13:25 EDT | | Modified | Nov 27, 2011 22:41 EDT | | Reporter | Kevin Grigorenko |

Description

Build Identifier: Trunk

Attached is a proposed patch which allows an org.eclipse.mat.report.report extension point to specify isInOverviewReportsList="true" so that it shows up in the list of reports in the Overview Pane when opening a dump. For example, I would like to be able to add a product overview report with the IBM Extensions for Memory Analyzer installed. I've also updated the leak suspects and top components reports to utilize this extension point attribute.

Reproducible: Always

Steps to Reproduce:
N/A

eclipsewebmaster avatar May 08 '24 18:05 eclipsewebmaster

By Kevin Grigorenko on Oct 21, 2011 13:26

Created attachment 205749 Allow report extensions to display in Overview Pane

:notepad_spiral: patch_extendoverview.patch

eclipsewebmaster avatar May 08 '24 18:05 eclipsewebmaster

By Andrew Johnson on Nov 23, 2011 07:35

How is this bug related to bug 353363 ?

I notice that currently there is also a Additional Information section added if a valid query is found named starting with "supplement_". Is this the best way of adding queries to the overview pane?

eclipsewebmaster avatar May 08 '24 18:05 eclipsewebmaster

By Kevin Grigorenko on Nov 27, 2011 22:40

(In reply to comment #2)

How is this bug related to bug 353363 ?

Whoops! I forgot I had already submitted this. I'll close 353363 as DUP of this.

I notice that currently there is also a Additional Information section added if a valid query is found named starting with "supplement_". Is this the best way of adding queries to the overview pane?

I wasn't aware of this. It's a bit awkward in that it requires a prefix in the name of the query -- I think it would be better to have some type of metadata instead (for example, in the extension point XML definition). Nevertheless, this will work for my pursposes, thanks (and it seems this has been around for years)!

I still think the proposed patch is useful for reports instead of queries, but I'm fine if this bug is closed.

eclipsewebmaster avatar May 08 '24 18:05 eclipsewebmaster

By Kevin Grigorenko on Nov 27, 2011 22:41

*** Bug 353363 has been marked as a duplicate of this bug. ***

eclipsewebmaster avatar May 08 '24 18:05 eclipsewebmaster