lsp4j icon indicating copy to clipboard operation
lsp4j copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-lsp4j

Add module-info to the modules

Open Thihup opened this issue 1 year ago • 2 comments

Adding a module-info to the modules will make the life easier for whom wants to create a JLinked runtime including only the necessary modules. Most LSP servers are standalone programs, so it makes sense to create a LSP server using a JLinked runtime.

Thihup avatar May 02 '24 11:05 Thihup

Totally agree. BSL Language Server is packaged via jpackage and runtime image is quite huge.

nixel2007 avatar May 02 '24 16:05 nixel2007

I will be happy to review a PR that provides the needed info. Please tag me in such a PR.

jonahgraham avatar May 14 '24 13:05 jonahgraham

@Thihup this seems to have caused a significant regression. Please see #855 - I am hoping we can resolve the issue without needing to revert it. Please share your thoughts.

jonahgraham avatar Nov 26 '24 15:11 jonahgraham

maybe there is something that makes buildship configure the module thing correctly

cdietrich avatar Nov 26 '24 15:11 cdietrich

@Thihup this seems to have caused a significant regression. Please see #855 - I am hoping we can resolve the issue without needing to revert it. Please share your thoughts.

We would like to release 0.24.0, but we need to resolve or revert this change before we can do that. @Thihup are you able to review the issue raised in #855 so we can proceed?

jonahgraham avatar Jan 27 '25 20:01 jonahgraham

@Thihup this seems to have caused a significant regression. Please see #855 - I am hoping we can resolve the issue without needing to revert it. Please share your thoughts.

We would like to release 0.24.0, but we need to resolve or revert this change before we can do that. @Thihup are you able to review the issue raised in #855 so we can proceed?

Hi. I am currently unable to fix it. Reverting it is fine for me.

Thihup avatar Jan 27 '25 20:01 Thihup