iceoryx
iceoryx copied to clipboard
iox-#2370: Add pre-commit setup (for buildifier)
Notes for Reviewer
Add pre-commit setup and replace buildifier machinery with it.
https://github.com/eclipse-iceoryx/iceoryx/actions/runs/13865819821/job/38804565572?pr=2441:
Note that it says "format" Bazel files, but it does lint as well.
Example:
Pre-Review Checklist for the PR Author
- [x] Code follows the coding style of CONTRIBUTING.md
- [x] Tests follow the best practice for testing
- [ ] Changelog updated in the unreleased section including API breaking changes
- [x] Branch follows the naming format (
iox-123-this-is-a-branch) - [x] Commits messages are according to this guideline
- [x] Commit messages have the issue ID (
iox-#123 commit text) - [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
- [x] Commit messages have the issue ID (
- [x] Update the PR title
- Follow the same conventions as for commit messages
- Link to the relevant issue
- [x] Relevant issues are linked
- [x] Add sensible notes for the reviewer
- [x] All checks have passed (except
task-list-completed) - [ ] Assign PR to reviewer
Checklist for the PR Reviewer
- [ ] Consider a second reviewer for complex new features or larger refactorings
- [ ] Commits are properly organized and messages are according to the guideline
- [ ] Code according to our coding style and naming conventions
- [ ] Unit tests have been written for new behavior
- [ ] Public API changes are documented via doxygen
- [ ] Copyright owner are updated in the changed files
- [ ] All touched (C/C++) source code files from
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txt - [ ] PR title describes the changes
Post-review Checklist for the PR Author
- [ ] All open points are addressed and tracked via issues
References
- Closes TBD
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.25%. Comparing base (
2fc7a5f) to head (d49c10a).
Additional details and impacted files
@@ Coverage Diff @@
## main #2441 +/- ##
==========================================
- Coverage 78.26% 78.25% -0.01%
==========================================
Files 445 445
Lines 17091 17091
Branches 2373 2373
==========================================
- Hits 13376 13375 -1
Misses 2835 2835
- Partials 880 881 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.05% <ø> (-0.01%) |
:arrow_down: |
| unittests_timing | 15.32% <ø> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.