che-server icon indicating copy to clipboard operation
che-server copied to clipboard

Avoid using token in testcase

Open netomi opened this issue 1 year ago • 2 comments

This PR is triggered by a security alert wrt a token used in a test case.

I updated the testcase to use a dummy value instead.

netomi avatar Jul 18 '24 17:07 netomi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: netomi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 18 '24 17:07 openshift-ci[bot]

/retest

artaleks9 avatar Jul 22 '24 13:07 artaleks9

The tests CI OpenShift are fail on the deploy Che with error:

 Back-off pulling image "quay.io/eclipse/che-server:pr-704"

because the build-pr-check action is failed.

@vinokurig , could you take a look on build-pr-check GitHub action..what could happened?

artaleks9 avatar Jul 22 '24 15:07 artaleks9

/retest

vinokurig avatar Jul 23 '24 08:07 vinokurig

The build-pr-check failed on login to docker.io step. I wonder why this step is skipped in pull requests opened by org members?

vinokurig avatar Jul 23 '24 09:07 vinokurig

so secrets are not provisioned to workflows running for PRs from outside collaborators, so this step should be skipped in PRs afaict.

netomi avatar Jul 23 '24 09:07 netomi

@netomi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-azure-no-pat-oauth-flow-raw-devfile-url e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-azure-no-pat-oauth-flow-raw-devfile-url
ci/prow/v14-azure-no-pat-oauth-flow-ssh-url e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-azure-no-pat-oauth-flow-ssh-url
ci/prow/v14-gitlab-with-pat-setup-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-gitlab-with-pat-setup-flow
ci/prow/v14-azure-no-pat-oauth-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-azure-no-pat-oauth-flow
ci/prow/v14-gitlab-no-pat-oauth-flow-ssh-url e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-gitlab-no-pat-oauth-flow-ssh-url
ci/prow/v14-gitlab-no-pat-oauth-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-gitlab-no-pat-oauth-flow
ci/prow/v14-gitlab-with-oauth-setup-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-gitlab-with-oauth-setup-flow
ci/prow/v14-che-smoke-test e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-che-smoke-test
ci/prow/v14-gitea-no-pat-oauth-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-gitea-no-pat-oauth-flow
ci/prow/v14-azure-with-pat-setup-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-azure-with-pat-setup-flow
ci/prow/v14-bitbucket-no-pat-oauth-flow-ssh-url e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-bitbucket-no-pat-oauth-flow-ssh-url
ci/prow/v14-gitlab-no-pat-oauth-flow-raw-devfile-url e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-gitlab-no-pat-oauth-flow-raw-devfile-url
ci/prow/v14-github-no-pat-oauth-flow-ssh-url e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-github-no-pat-oauth-flow-ssh-url
ci/prow/v14-github-no-pat-oauth-flow-raw-devfile-url e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-github-no-pat-oauth-flow-raw-devfile-url
ci/prow/v14-bitbucket-no-pat-oauth-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-bitbucket-no-pat-oauth-flow
ci/prow/v14-github-no-pat-oauth-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-github-no-pat-oauth-flow
ci/prow/v14-github-with-pat-setup-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-github-with-pat-setup-flow
ci/prow/v14-bitbucket-no-pat-oauth-flow-raw-devfile-url e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-bitbucket-no-pat-oauth-flow-raw-devfile-url
ci/prow/v14-gitea-with-pat-setup-flow e6e586b00f0a0b28912377d4f60462b04cfe77e1 link true /test v14-gitea-with-pat-setup-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 23 '24 09:07 openshift-ci[bot]

closing in favor of https://github.com/eclipse-che/che-server/pull/707

vinokurig avatar Jul 23 '24 14:07 vinokurig

Created an issue about the pull request check: https://github.com/eclipse-che/che/issues/23053

vinokurig avatar Jul 23 '24 14:07 vinokurig