che-server
che-server copied to clipboard
eclipse-che
Support raw devfile urls without yaml extension
What does this PR do?
On handling raw devfile urls, request content by the url, and check if the content is a devfile. If yes treat the url as a raw devfile url.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes https://github.com/eclipse-che/che/issues/22937
How to test this PR?
- Deploy che with the PR image:
quay.io/eclipse/che-server:pr-683 - Start a workspace from a raw devfile url without
yamlextension, e.g.https://raw.githubusercontent.com/vinokurig/test/master/parent
See: workspace starts successfully.
PR Checklist
As the author of this Pull Request I made sure that:
- [ ] The Eclipse Contributor Agreement is valid
- [ ] Code produced is complete
- [ ] Code builds without errors
- [ ] Tests are covering the bugfix
- [ ] The repository devfile is up to date and works
- [ ] Sections
What issues does this PR fix or referenceandHow to test this PRcompleted - [ ] Relevant user documentation updated
- [ ] Relevant contributing documentation updated
- [ ] CI/CD changes implemented, documented and communicated
Reviewers
Reviewers, please comment how you tested the PR when approving it.
@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/v14-gitlab-with-oauth-setup-flow | 974595ed4b5e828c7be9965f13d58339a2f307a2 | link | true | /test v14-gitlab-with-oauth-setup-flow |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
The gitlab-with-oauth-setup-flow is failed.
Maybe, it's related to UI locator change
I need to investigate it.
@vinokurig the gitlab-with-oauth-setup-flow is fail due to the known issue -> https://github.com/eclipse-che/che/issues/22953
The Views and More Actions menu is not available (see the screenshot)
@RomanNikitenko said this problem was resolved in the next 4 days ago, but, it seems, this che-sever image is not included the fix.
@vinokurig Do we have an opportunity update the PR image, to rerun the gitlab-with-oauth-setup-flow test and verify it?
Anyway I've checked the functionality related to the PR and OAuth - works properly.
@artaleks9
Do we have an opportunity update the PR image, to rerun the gitlab-with-oauth-setup-flow test and verify it?
The PR image is already up to date with the main branch.
@artaleks9 If the failure is a known issue, can we go with the current changes?
I see on the screenshot that editor version is pretty old - it was built 2 weeks ago. I think editor image should be updated for testing.
| @artaleks9 If the failure is a known issue, can we go with the current changes? I think, yes
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Build 3.15 :: get-sources-rhpkg-container-build_3.x/6766:
server : 3.x :: Build 61397668 : quay.io/devspaces/server-rhel8:3.15-1
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4649 triggered
Build 3.15 :: get-sources-rhpkg-container-build_3.x/6767:
devspaces-operator-bundle : 3.x :: Failed in 61398909 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay