trace-server-protocol icon indicating copy to clipboard operation
trace-server-protocol copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-cdt-cloud

PUT to update for experiments should not use actions in payload

Open bhufmann opened this issue 3 years ago • 3 comments

PUT for experiments command should not use actions in payload (see below). To add or remove traces provide a list of traces UUIDs in the payload and the server needs to validate whether traces need to be added or removed from the experiment by comparing the lists of traces on the server and in the command

image

bhufmann avatar Dec 09 '21 18:12 bhufmann

related discussion: https://github.com/theia-ide/theia-trace-extension/issues/608

bhufmann avatar Feb 11 '22 22:02 bhufmann

Way forward is defined in this ADR: https://github.com/eclipse-cdt-cloud/theia-trace-extension/pull/688

bhufmann avatar Mar 28 '22 15:03 bhufmann

#96 proposes a different way to provide actions to the TSP. Adding/removing traces or renaming should be done in a similar way. These actions changing the resource in a way that a new resource is created:

POST /tsp/api/experiments/{expUUID}:add POST /tsp/api/experiments/{expUUID}:remove POST /tsp/api/experiments/{expUUID}:rename

Note that ADR https://github.com/eclipse-cdt-cloud/theia-trace-extension/pull/688 needs to be updated for that.

bhufmann avatar Nov 02 '23 14:11 bhufmann