theia-trace-extension icon indicating copy to clipboard operation
theia-trace-extension copied to clipboard

Support next/previous with keyboard across pages (pagination) in table-output-component

Open bhufmann opened this issue 3 years ago • 3 comments
trafficstars

PR #813 upgrades AgGrid to a later version and it required to use pagination. However, selecting an event across pages using arrow down/up or page down/up is not switching to the next page.

bhufmann avatar Oct 12 '22 17:10 bhufmann

Picking up this issue.

hoangphamEclipse avatar Oct 26 '22 20:10 hoangphamEclipse

I am working on this issue and I am running into some roadblocks. @Rodrigoplp-work can you help me with these questions since you worked on AgGrid?

  1. When users use the Arrow Up to navigate in the view, when they hit the very first row in the data set and press up again, the focus will move into the header (as seen here). This is the default behavior of the AgGrid. Should we modify this behaviour?

  2. UI/UX wise, when user switch pages, we should focus on the cell that is 1) in the same column as previously selected and 2) on the first and last row when we are going forward and backward a page, respectively. I still cannot get this working. I tried using gridAPI.setFocusedCell() but it failed.

hoangphamEclipse avatar Nov 10 '22 20:11 hoangphamEclipse

  1. When users use the Arrow Up to navigate in the view, when they hit the very first row in the data set and press up again, the focus will move into the header (as seen here). This is the default behavior of the AgGrid. Should we modify this behaviour?

This issue is resolved.

hoangphamEclipse avatar Nov 15 '22 16:11 hoangphamEclipse