cdt-gdb-adapter icon indicating copy to clipboard operation
cdt-gdb-adapter copied to clipboard

Incorrect address (pc) resolution in DisassembleRequest

Open asimgunes opened this issue 11 months ago • 0 comments

During the debug session, when user navigates and opens the Disassembly View in the VSCode, the Disassembly View focuses on an incorrect line when it is compared program counter (pc) register as shown above:

image

After a review, I found that the current implementation of the disassembleRequest method at the GDBDebugSessionBase class are not handling the instructionOffset parameters. It seems the disassembleRequest implementation requires to be updated to match the DAP reference. https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disassemble

@jonahgraham and I already discussed the issue previously, planning to propose an update to solve the issue.

asimgunes avatar Nov 18 '24 14:11 asimgunes