bisonapp icon indicating copy to clipboard operation
bisonapp copied to clipboard

feat: add persistent app layouts to template

Open mcavaliere opened this issue 3 years ago • 1 comments
trafficstars

Fix #242

Changes

Sets _app.tsx up to render a getLayout function for any page (or component) if it exists. This allows faster navigation between pages, since layouts that are the same between pages will not be re-rendered (since their element subtrees are the same).

References:

Also includes:

  • References shared footer component in logged in / logged out layouts
  • Makes nav links consistently use next/link around the Chakra Link component
  • Adds 3 placeholder pages for the default nav links

Screenshots

(prefer animated gif)

Checklist

  • [ ] Requires dependency update?
  • [ ] Generating a new app works

Fixes #xxx

mcavaliere avatar Jan 18 '22 22:01 mcavaliere

We should revisit this PR with the new Layout features dropping

mthomps4 avatar May 25 '22 20:05 mthomps4

Almost a year old -- closing

mthomps4 avatar Nov 04 '22 14:11 mthomps4

😢

mcavaliere avatar Nov 04 '22 15:11 mcavaliere

😢

Can re-open with new Next stuff

mthomps4 avatar Nov 04 '22 15:11 mthomps4