r2modmanPlus icon indicating copy to clipboard operation
r2modmanPlus copied to clipboard

Make Uninstall Buttons Red

Open Decryptu opened this issue 1 year ago • 3 comments

Enhancements to Uninstall Buttons

In line with the suggestions discussed in this thread:

Changes:

  • LocalModCard.vue: Applied is-danger class to the "Uninstall" button for visual emphasis on action's risk.
  • UninstallModModal.vue: Used is-warning for the "Uninstall All" button to distinguish between single and bulk uninstall actions.
  • custom.scss: Updated to ensure is-danger class applies correct border and background color changes on hover, focus, and active states.

Visuals:

  • Uninstall button now red: Uninstall Button
  • Uninstall All button in modal: Uninstall All Modal

Decryptu avatar Feb 16 '24 13:02 Decryptu

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 16 '24 13:02 CLAassistant

To further the reply from the discussion on https://github.com/ebkr/r2modmanPlus/discussions/1223

I like the idea of having some distinguishing factor for uninstall however I do have some reservations:

  1. The colour is too bright. It draws away focus from the other elements which I'd argue are far more important. It's kind of like having the manager say "hey, uninstall this mod!". I don't think muting the colours would even necessarily solve this, so it's potentially worth avoiding entirely on the normal mod list screen.
  2. I'm not a huge fan of using is-danger to mark the uninstall button. is-danger is more for an irreversible action. The act of clicking Uninstall on the mod list view does not uninstall the mod unless it's a single item, but in that case I definitely see it as less of a problem as it's extremely easy to get it back from the online list. Even if the action is red in that scenario, it's not like there's a secondary prompt. Colour alone isn't really a good visual indicator. It's also worth noting that the Uninstall X only is not marked as is-danger which would be identical.
  3. The Uninstall all action isn't really a warning in this case as it's the finalization of the action. This is probably more severe than Uninstall X only as it will include dependent mods too.

ebkr avatar Feb 16 '24 22:02 ebkr

Feel free to share any color preferences you have in mind, and I can make the updates accordingly. Alternatively, I can experiment with some options and share screenshots for you to see how they might look. I've noticed that Bulma's color options seem limited Bulma Colors, but it might not be a significant issue, and we could stick with the original color scheme before the changes if that works better.

Decryptu avatar Feb 17 '24 11:02 Decryptu