easybuild-framework icon indicating copy to clipboard operation
easybuild-framework copied to clipboard

added code to support multi_deps for extensions only

Open mboisson opened this issue 5 years ago • 6 comments
trafficstars

This can save valuable time when only the extensions require multi_deps. For example, this could be used to install Matlab, or TensorRT with python bindings, without re-installing those for each version of python.

Ideally, in this case, I would want to skip extracting the source, and keep the version that was built in the previous iteration, but I could not figure out the right combination of options for that, so I kept extracting the source here.

I tested this with the TensorRT recipe, which installs python wheels that are part of the extracted binary.

I would like @bartoldeman and @boegel's comments on this PR.

mboisson avatar Apr 28 '20 02:04 mboisson

Looks sane but I'll defer to @boegel

akesandgren avatar May 01 '20 08:05 akesandgren

Will this be included in 4.2.1 @boegel ?

mboisson avatar May 14 '20 20:05 mboisson

@mboisson Tests are missing, so this is not ready to go in yet imho...

I haven't had a chance to closely follow up on this, but i don't think this should block the 4.2.1 release (which we hope to push out any day now).

I'm moving this to the milestone for the release after 4.2.1...

boegel avatar May 19 '20 07:05 boegel

@boegel, what kind of test would you like to see ? I'm not sure how to test this.

mboisson avatar May 19 '20 14:05 mboisson

@mboisson To get this covered in the tests, see how we test the use of multi_deps?

boegel avatar Oct 14 '20 13:10 boegel

I'm sorry, I don't have time to work on tests at the moment.

mboisson avatar Oct 14 '20 15:10 mboisson