If left toggled off when VSCode is closed, you lose all your settings

[Haffi921]

• VSCode Version: Version: 1.48.1 Commit: 3dd905126b34dcd4de81fa624eb3a8cbe7485f13 Date: 2020-08-19T17:09:41.484Z (5 days ago) Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Darwin x64 19.6.0
• OS Version: MacOS Catalina 10.15.6

Steps to Reproduce:

1. Have excluded files enabled. Add rules such as **/node_modules or **/.vscode in settings "Files: Exclude"
2. Toggle excluded files, i.e. Show excluded files
3. Close project or VSCode
4. Open up again
5. See that toggling excluded files has no effect 5a. In settings "Files: Exclude", the rules you added in step 1 are no longer there.

Perhaps, it is possible to make it so that this extension restores excluded files settings before closing.

[ftzi]

I just found that it changes all the props in files.exclude in settings.json from true to false, and sometimes it will stick to false.

[ftzi]

@eamodio can you take a look at it? I have to almost everyday replace the falses with trues in my settings.json. Not a big deal because I select them all and replace the ones in selection, but still is somewhat annoying. Using it for like 2 months so it happened some good times lol it may also happen on some different unknown occasions as it happens more often than I close my VsCode.

Maybe instead of keeping track of each item, toggling the button should just set all values under "files.exclude" to false or true.

[eamodio]

Can you please see if this issue is still reproducible in the pre-release edition? Thanks!

You can switch to the pre-release edition, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

[github-actions[bot]]

This issue needs more information and has not had recent activity. Please provide the missing information or it will be closed in 7 days. Thanks!

[ftzi]

~~Hi @eamodio! Thanks for the update. I still hadn't issues with it!~~

@eamodio Actually, it just happened again: I had one VsCode window, opened another one where I switched the visibility and closed it, and on the first window, the switch won't change a thing. I still suggest that your extension just change all the files.exclude values to true or false, without having a state.

[guicbrito]

I can confirm this bug still exists. I end up having to manually change all files excludes from false to true, when the bug happens.

[russeg]

had this problem, so i used "Peek Hidden Files" extension instead. does not have a button to toggle, but never bugged on me.