Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[23265] Allow creation of built-in content filters with different type name (backport #5867)

Open mergify[bot] opened this issue 6 months ago • 1 comments

Description

This fixes a bug that disallows the creation of built-in content filters when the type support is registered with a custom type name.

@Mergifyio backport 3.2.x 2.14.x

This PR is on top of the following one, and should be merged after it:

  • https://github.com/eProsima/Fast-DDS/pull/5861

Contributor Checklist

  • [x] Commit messages follow the project guidelines.

  • [x] The code follows the style guidelines of this project.

  • [x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • [x] Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • [x] Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • [x] Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • [x] Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [x] The title and description correctly express the PR's purpose.
  • [x] Check contributor checklist is correct.
  • [x] If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • [x] Check CI results: changes do not issue any warning.
  • [x] Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5867 done by [Mergify](https://mergify.com).

mergify[bot] avatar Jun 13 '25 15:06 mergify[bot]

Cherry-pick of 92260c2de86ada48d921913cfe424f7874169ec1 has failed:

On branch mergify/bp/2.14.x/pr-5867
Your branch is up to date with 'origin/2.14.x'.

You are currently cherry-picking commit 92260c2d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/unittest/dds/topic/DDSSQLFilter/DDSSQLFilterTests.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cpp/fastdds/topic/DDSSQLFilter/DDSFilterFactory.cpp
	both modified:   test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] avatar Jun 13 '25 15:06 mergify[bot]