remove aws sdk, require local_aws

[durzo]

trafficstars

The bundled AWS PHP SDK is conflicting with other AWS plugins in our site. this can be solved by removing the vendor bundle and depending on https://github.com/catalyst/moodle-local_aws for the sdk.

Currently this is breaking our other plugins, ala:

PHP Fatal error:  Cannot redeclare Aws\constantly() (previously declared in mod/quiz/accessrule/proctoring/vendor/aws/aws-sdk-php/src/functions.php:20) in local/aws/sdk/Aws/functions.php on line 20

Fatal error: Cannot redeclare Aws\constantly() (previously declared in mod/quiz/accessrule/proctoring/vendor/aws/aws-sdk-php/src/functions.php:20) in local/aws/sdk/Aws/functions.php on line 20

And we have had to uninstall this plugin from our sites, but it would be great if it could work again

[jhutch1]

I also got this problem. I was able to resolve it by commenting out these lines in mod/quiz/accessrule/proctoring/vendor/aws/aws-sdk-php/src/functions.php

20-23 33-40 50-55 67-74 84-98 113-126 143-166 171-174 188-198 212-240 254-267 274-288 295-309 318-338 350-371 385-418 426-433 441-444 455-465 474-504 512-521

Then commenting out these lines in mod/quiz/accessrule/proctoring/vendor/guzzlehttp/guzzle/src/functions.php

16-19 29-32 43-46 59-62 69-72 89-92 100-103 126-129 147-150 164-167

Not very elegant, and your suggested solution is much better (relying on local_aws), but if you need it in a hurry this seems to work.

[shadman-ahmed-bs23]

As we have removed AWS face match method from free version, closing this PR.