Erik Koopmans

Results 40 comments of Erik Koopmans

Hi @hakimio, thanks for the PR! And sorry I didn't have a look sooner. dom-to-image uses svg `` rendering, which has mixed support (doesn't work at all in IE11 and...

Okay, fair enough. Like I said I am open to supporting multiple renderers, and I have looked into dom-to-image and other `foreignObject` options in the past. I was discouraged by...

Hi @YuriTu, I have a couple thoughts. The most likely cause is to do with how I clone elements - it's not perfect, and some CSS could end up getting...

@nathanboktae this will bring `visible` into parity with `displayed` - let me know if there's any changed you'd like.

@awto I found that cross-env didn't work, it just converted `$npm_package_version` to the text `%npm_package_version%`, which was passed as-is without being evaluated anywhere along the way. I tried cross-env-shell (as...

Hah yep, I ran into a problem further downstream - a bit hard to replicate, but basically it was parsing `text$var` inconsistently (one part of the command composed them properly,...

Just chiming in - the demo works fine (though a bit slow, and definitely running hot) on my Macbook Pro 2019, Chrome 104.0.5112.101. The engine is very cool, keep up...

I don't have all the context here, but maybe it would make sense for the tooltip to never be `aria-hidden`?

Yep, @dlockhart in my bit of testing (on the localhost testing page for `tooltip`), it was only reading the `labelledby` when the target wasn't `aria-hidden`, but I didn't investigate too...

Sounds like this may have been a CORS issue - if so, the `proxy` and/or `useCORS` options on html2canvas could help: https://html2canvas.hertzen.com/configuration