ebayui-core icon indicating copy to clipboard operation
ebayui-core copied to clipboard

Published 20 hours ago • verified publisher icon eBay

video: closed captioning

Open ianmcburnie opened this issue 4 years ago • 5 comments

details to follow...

ianmcburnie avatar Jun 28 '21 18:06 ianmcburnie

@agliga I believe you already took care of this?

ianmcburnie avatar Jul 07 '21 03:07 ianmcburnie

This is partially working. I think we need a video example with CC to see if it actually works. There is another fix needed from Shaka https://github.com/google/shaka-player/issues/2676

agliga avatar Jul 09 '21 16:07 agliga

Hello @agliga, I am chiming in from Shaka.

The following manifest https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd could work as a testing example.

In advance, once #3465 is merged, closed captions should work natively by adding 'captions' to your control panel elements at src/components/ebay-video/component.js.

https://github.com/eBay/ebayui-core/blob/4c4e15f4e9b3c5509c5242b8937cabeb8439c95d/src/components/ebay-video/component.js#L9-L17

Let me know if you encounter any issues doing so, happy to help!

nbcl avatar Jul 12 '21 18:07 nbcl

As of today, the PR mentioned above hasn't been merged, but it should be soon.. it has one approval

austingardner avatar Jul 14 '21 21:07 austingardner

The PR was merged, so shaka just needs a bump, and the addition of 'caption' to the icon list array. Will have to discuss with video team about where they want the CC icon.

austingardner avatar Aug 13 '21 00:08 austingardner